Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance enhancement by skipping the (unnecessary) checks in ArraySegment #301

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Conversation

decipherer
Copy link
Contributor

Another fix for this issue: #289

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@piksel
Copy link
Member

piksel commented Jan 14, 2019

This is the same change as the one I made to Adler32, which is basically undoing the simplifications that the ArraySegment PR introduced. Since those introduce a significant slow down, the original (slightly more verbose) should be kept.

The reason for the failed checks is due to bad commit in master and not related to this PR.

@piksel piksel merged commit 1847274 into icsharpcode:master Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants