Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tar): create translated files in temp #645

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Conversation

piksel
Copy link
Member

@piksel piksel commented Jun 30, 2021

In #622 the temporary file path was changed to use Path.GetRandomFileName() instead of Path.GetTempFileName(), which resulted in the current working directory being used for storing the translated tar files while creating archives.
This instead uses the PathUtils.GetTempFileName() that was created for this purpose.

Fixes #644

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #645 (dcf5e10) into master (8c0a169) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #645   +/-   ##
=======================================
  Coverage   73.30%   73.30%           
=======================================
  Files          68       68           
  Lines        8309     8309           
=======================================
  Hits         6091     6091           
  Misses       2218     2218           
Impacted Files Coverage Δ
src/ICSharpCode.SharpZipLib/Core/PathUtils.cs 100.00% <ø> (ø)
src/ICSharpCode.SharpZipLib/Tar/TarArchive.cs 43.12% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c0a169...dcf5e10. Read the comment docs.

@piksel piksel merged commit ac96e60 into master Jun 30, 2021
@piksel piksel deleted the fix/tar-ascii-tempfile branch June 30, 2021 10:16
HowToDoThis added a commit to HowToDoThis/SharpZipLib that referenced this pull request Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant