Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Improved TEAL search error message #14

Merged
2 commits merged into from
Sep 1, 2020

Conversation

PaulTalbot-INL
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL commented Aug 31, 2020


Pull Request Description

What issue does this change request address?

Closes #13

What are the significant changes in functionality due to this change request?
  • Adds a more intelligent error if TEAL is not found during HERON initial run
  • Adds docstrings and formatting fixes, especially for the template_driver.py
  • Adds unused <Optimizer> template to RAVEN outer.xml, which will be used in the future but is passive for now

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
  • 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

@PaulTalbot-INL PaulTalbot-INL requested a review from a user August 31, 2020 20:55
@PaulTalbot-INL PaulTalbot-INL changed the title Find teal err [TASK] Improved TEAL search error message Aug 31, 2020
@ghost ghost merged commit 1ef1d61 into idaholab:devel Sep 1, 2020
@PaulTalbot-INL
Copy link
Collaborator Author

How did you get the automated tests to run (item 4 on the checklist)?

@PaulTalbot-INL PaulTalbot-INL deleted the find_teal_err branch January 31, 2022 21:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Make a better TEAL error note.
1 participant