Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt mode #17

Merged
3 commits merged into from
Sep 9, 2020
Merged

Opt mode #17

3 commits merged into from
Sep 9, 2020

Conversation

PaulTalbot-INL
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL commented Sep 8, 2020


Pull Request Description

What issue does this change request address?

Closes #11

What are the significant changes in functionality due to this change request?

Implements the option to use "opt" mode instead of "sweep" in <Case><mode>.

The test is as fast as I can realistically get it without losing its purpose, but it still takes 140 seconds to run in parallel, so I marked the test as heavy for now. A few things could be done to improve this:

  • Don't reset persistence on rejected potential opt points
  • Speed up the startup of RAVEN (inner runs are taking 8 seconds, 4 of which are after startup)
  • Don't force rerunning of previous opt points on rejection; deterministic codes don't need this, and it at least doubles the run time.

We can re-address making the test non-heavy when we can get it down around 30 seconds or less run time.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
  • 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

@PaulTalbot-INL PaulTalbot-INL requested a review from a user September 8, 2020 15:50
@ghost ghost merged commit 30aa5fe into idaholab:devel Sep 9, 2020
@PaulTalbot-INL PaulTalbot-INL deleted the optz_option branch January 31, 2022 21:01
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimization mode not running
1 participant