-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed HERON path variable in collect_tex.py #185
Conversation
…umentation workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. No significant functionality changes, just need tests to pass and it can be merged. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor change and a comment.
@dylanjm looks like we were reviewing this at the same time! Sorry, @AnthoneyGriffith I'm a bit more picky 😛 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Thanks for cleaning this up!
Job CentOS 8 on 89700d6 : invalidated by @dgarrett622 failed in updating RAVEN |
Changed heron_path in collect_tex.py so that the HERON module is found when compiling the documentation via make_docs.sh.
Pull Request Description
What issue does this change request address?
#184
What are the significant changes in functionality due to this change request?
No changes in functionality.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.