Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed HERON path variable in collect_tex.py #185

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Changed HERON path variable in collect_tex.py #185

merged 2 commits into from
Jul 20, 2022

Conversation

AnthoneyGriffith
Copy link
Contributor

@AnthoneyGriffith AnthoneyGriffith commented Jul 19, 2022

Changed heron_path in collect_tex.py so that the HERON module is found when compiling the documentation via make_docs.sh.

Pull Request Description

What issue does this change request address?

#184

What are the significant changes in functionality due to this change request?

No changes in functionality.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
  • 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

dylanjm
dylanjm previously approved these changes Jul 19, 2022
Copy link
Collaborator

@dylanjm dylanjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. No significant functionality changes, just need tests to pass and it can be merged. Thanks!

Copy link
Collaborator

@dgarrett622 dgarrett622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor change and a comment.

doc/user_manual/script/collect_tex.py Show resolved Hide resolved
doc/user_manual/script/collect_tex.py Outdated Show resolved Hide resolved
@dgarrett622
Copy link
Collaborator

@dylanjm looks like we were reviewing this at the same time! Sorry, @AnthoneyGriffith I'm a bit more picky 😛

Copy link
Collaborator

@dgarrett622 dgarrett622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Thanks for cleaning this up!

@moosebuild
Copy link
Collaborator

Job CentOS 8 on 89700d6 : invalidated by @dgarrett622

failed in updating RAVEN

@dgarrett622 dgarrett622 merged commit f55d88d into idaholab:devel Jul 20, 2022
@dgarrett622 dgarrett622 linked an issue Jul 20, 2022 that may be closed by this pull request
5 tasks
@AnthoneyGriffith AnthoneyGriffith deleted the docBuildError branch August 5, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DEFECT] Documentation is failing to build on MacOS
4 participants