Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOPED2 #188

Merged
merged 21 commits into from
Aug 5, 2022
Merged

MOPED2 #188

merged 21 commits into from
Aug 5, 2022

Conversation

AnthoneyGriffith
Copy link
Contributor

@AnthoneyGriffith AnthoneyGriffith commented Jul 21, 2022


Pull Request Description

What issue does this change request address?

#186

What are the significant changes in functionality due to this change request?

Allows user to select alternate workflow for optimization/analysis.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
  • 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

@dylanjm dylanjm closed this Jul 21, 2022
@dylanjm dylanjm reopened this Jul 21, 2022
@dylanjm dylanjm mentioned this pull request Jul 21, 2022
9 tasks
Copy link
Collaborator

@dylanjm dylanjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more changes to consider.

src/main.py Outdated Show resolved Hide resolved
src/Moped.py Outdated Show resolved Hide resolved
src/Moped.py Show resolved Hide resolved
src/Moped.py Outdated Show resolved Hide resolved
src/Moped.py Outdated Show resolved Hide resolved
src/Moped.py Outdated Show resolved Hide resolved
src/Moped.py Outdated Show resolved Hide resolved
src/Moped.py Outdated Show resolved Hide resolved
src/Moped.py Outdated Show resolved Hide resolved
src/Moped.py Outdated Show resolved Hide resolved
…irectly from the input file. However, still in the middle of hammering out issues with with cashflow settings to verify MOPED against default HERON.
…irectly from the input file. However, still in the middle of hammering out issues with with cashflow settings to verify MOPED against default HERON.
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple little things to patch up. This is great stuff!

src/Moped.py Show resolved Hide resolved
src/Moped.py Show resolved Hide resolved
src/Moped.py Show resolved Hide resolved
src/Moped.py Outdated Show resolved Hide resolved
…ction to MOPED. Added integration tests for various functions of MOPED. This involved adding new test type to HERON.
PaulTalbot-INL
PaulTalbot-INL previously approved these changes Aug 3, 2022
@PaulTalbot-INL PaulTalbot-INL linked an issue Aug 3, 2022 that may be closed by this pull request
5 tasks
@PaulTalbot-INL
Copy link
Collaborator

Approved for merge once tests pass without further change. Nice work!

@PaulTalbot-INL
Copy link
Collaborator

It looks like some of your ARMAs were trained before Jacob made changes to the library use, so they'll need to be retrained and committed with the current devel of RAVEN.

@PaulTalbot-INL
Copy link
Collaborator

  File "/home/civet/civet/build_0/raven/ravenframework/SupervisedLearning/ARMA.py", line 1391, in writeXML
    armaNode.append(xmlUtils.newNode('std', text=arma.sigma))
  File "/home/civet/miniconda3/envs/raven_libraries/lib/python3.7/site-packages/statsmodels/base/wrapper.py", line 34, in __getattribute__
    obj = getattr(results, attr)
AttributeError: 'ARMAResults' object has no attribute 'sigma'
 ... Errors were encountered while running HERON.

Running test failed with exit code 1
(22F3/27) Failed (  4.59sec)/home/civet/civet/build_0/HERON/tests/integration_tests/workflows/MOPED/wind/Moped_wind
(23F3/27) Success(  2.26sec)/home/civet/civet/build_0/HERON/tests/unit_tests/component
(24F3/27) Success(  2.29sec)/home/civet/civet/build_0/HERON/tests/unit_tests/ValuedParams/parametric
SKIPPED ({'heavy'} is not a subset of {'normal'})
(25F3/27) Skipped(  None!  )/home/civet/civet/build_0/HERON/tests/workshop/simple/Workshop_HTSE_Simple1
SKIPPED ({'heavy'} is not a subset of {'normal'})
(26F3/27) Skipped(  None!  )/home/civet/civet/build_0/HERON/tests/workshop/wind/Workshop_Wind
(27F3/27) Success( 72.34sec)/home/civet/civet/build_0/HERON/tests/integration_tests/mechanics/multirun_sweep_opt/MultiRun_Opt
FAILED:
Failed /home/civet/civet/build_0/HERON/tests/integration_tests/workflows/MOPED/simple/Moped_simple
Failed /home/civet/civet/build_0/HERON/tests/integration_tests/workflows/MOPED/synthetic_cashflows/Moped_synthetic_cashflows
Failed /home/civet/civet/build_0/HERON/tests/integration_tests/workflows/MOPED/wind/Moped_wind

PASSED: 20
SKIPPED: 4
FAILED: 3
... there were failed tests for plugin HERON!

PaulTalbot-INL
PaulTalbot-INL previously approved these changes Aug 4, 2022
@PaulTalbot-INL
Copy link
Collaborator

Good to merge if tests pass without further modification.

@moosebuild
Copy link
Collaborator

Job CentOS 8 on 1c82755 : invalidated by @dgarrett622

Try this again now that HERON and TEAL submodule updates are merged into RAVEN

@PaulTalbot-INL PaulTalbot-INL dismissed dylanjm’s stale review August 5, 2022 14:48

changes have been implemented

@PaulTalbot-INL PaulTalbot-INL merged commit a521775 into idaholab:devel Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Alternative Workflow
5 participants