-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOPED2 #188
MOPED2 #188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more changes to consider.
…ording to PR comments.
…irectly from the input file. However, still in the middle of hammering out issues with with cashflow settings to verify MOPED against default HERON.
… descrepancy between MOPED and HERON.
…ording to PR comments.
…irectly from the input file. However, still in the middle of hammering out issues with with cashflow settings to verify MOPED against default HERON.
… descrepancy between MOPED and HERON.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple little things to patch up. This is great stuff!
…ction to MOPED. Added integration tests for various functions of MOPED. This involved adding new test type to HERON.
Approved for merge once tests pass without further change. Nice work! |
It looks like some of your ARMAs were trained before Jacob made changes to the library use, so they'll need to be retrained and committed with the current |
|
Good to merge if tests pass without further modification. |
Job CentOS 8 on 1c82755 : invalidated by @dgarrett622 Try this again now that HERON and TEAL submodule updates are merged into RAVEN |
Pull Request Description
What issue does this change request address?
#186
What are the significant changes in functionality due to this change request?
Allows user to select alternate workflow for optimization/analysis.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.