Initial Storage as Percentage

[PaulTalbot-INL]

---

Pull Request Description

What issue does this change request address?

Closes #243

What are the significant changes in functionality due to this change request?

Previously HERON did not check that initial stored resources did not exceed the capacity of the storage, which it logically should do.

In addition to addressing this, a backward incompatible change is introduced to change <initial_stored> from the amount of resource stored, to a percentage (0, 1) of the storage capacity that is filled, which scales better with optimizing storage size.

---

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

• 1. Review all computer code.
• 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
• 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
• 4. Automated Tests should pass.
• 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
• 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
• 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
• 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
• 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

[BotrosHanna-INL]

Hi Paul, I left a few minor comments. I also made sure that the tests are run successfully.

[BotrosHanna-INL]

If the goal is to change all the "initial stored" value in all the heron_input files, It seems that the (inital stored) value needs also to change in /workflows/MOPED/storage/moped_input.xml

[PaulTalbot-INL]

I left most of the them the same relative value, but changed the moped one to increase variety in the tests.