Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in ISO installer, prompt to format other drives for artifact storage rather than just doing it automatically #529

Closed
mmguero opened this issue Jul 31, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request iso relating to the ISO-installed environment for Malcolm and/or Hedgehog sensor For issues dealing with the Hedgehog OS capture sensor
Milestone

Comments

@mmguero
Copy link
Collaborator

mmguero commented Jul 31, 2024

As indicated in the documentation, Malcolm's installer ISO assumes all drives attached to the system are available to it for formatting and use, and this is pretty much automatic and baked-in to the ISO installer.

During the installation itself, this script determines the disk onto which Malcolm will be installed, and uses these rules (depending on the type of installation chosen) to partition that disk.

Then, at the end of the installation, the preseed creates a file called /etc/capture_storage_format which is detected on first boot and used to format the other non-system drives (for PCAP storage, database, etc.). The script that actually does that formatting is found at os-disk-config.py.

My suggestion here is that during the late user config (for Malcolm and Hedgehog ISO insallers) we prompt the user if they want to format those drives or not. If so, we do the touch (Malcolm, Hedgehog) there instead of doing it automatically. That way, on first boot, the extra drives will be formatted or not according to the user preference.

@mmguero mmguero added enhancement New feature or request iso relating to the ISO-installed environment for Malcolm and/or Hedgehog sensor For issues dealing with the Hedgehog OS capture sensor labels Jul 31, 2024
@mmguero mmguero added this to the z.staging milestone Jul 31, 2024
@mmguero
Copy link
Collaborator Author

mmguero commented Jul 31, 2024

See cisagov/discussions/325

@mmguero mmguero modified the milestones: z.staging, v24.08.0 Jul 31, 2024
@mmguero mmguero self-assigned this Aug 14, 2024
@mmguero
Copy link
Collaborator Author

mmguero commented Aug 14, 2024

  • /etc/capture_storage_format
  • /etc/capture_storage_format.crypt
  • /etc/capture_storage_format.none

mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Aug 14, 2024
…ifact storage rather than just doing it automatically
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Aug 14, 2024
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Aug 14, 2024
…ifact storage rather than just doing it automatically
@mmguero
Copy link
Collaborator Author

mmguero commented Aug 15, 2024

done and tested

@mmguero mmguero closed this as completed Aug 15, 2024
This was referenced Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iso relating to the ISO-installed environment for Malcolm and/or Hedgehog sensor For issues dealing with the Hedgehog OS capture sensor
Projects
Status: Released
Development

No branches or pull requests

1 participant