Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add "public" pseudo-segments for public IP addresses #542

Closed
mmguero opened this issue Aug 15, 2024 · 1 comment
Closed

add "public" pseudo-segments for public IP addresses #542

mmguero opened this issue Aug 15, 2024 · 1 comment
Assignees
@mmguero
Labels
enhancement New feature or request logstash Relating to Malcolm's use of Logstash
Milestone
v24.08.0

Comments

@mmguero
Copy link
Collaborator

mmguero commented Aug 15, 2024 •
edited
Loading

When enriching with netbox, source and destination network segments are populated from IP addresses.

@ee-hex-ee requested that we also put in "public" for a pseudo-segment (pseudo because it won't actually exist in netbox) for public IP addresses, so it will work in things like sankey diagrams.

Should it populate the cross-segment tag?
@mmguero mmguero added enhancement New feature or request logstash Relating to Malcolm's use of Logstash labels Aug 15, 2024
@mmguero mmguero modified the milestones: z.staging, v24.08.0 Aug 15, 2024
@mmguero mmguero self-assigned this Aug 15, 2024
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Aug 15, 2024
@mmguero
idaholab#542 add 'public' pseudo-segment for source/destination publi…
9dee43b 
…c IP addresses
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Aug 15, 2024
@mmguero
idaholab#542 add 'public' pseudo-segment for source/destination publi…
ea014c2 
…c IP addresses
mmguero added a commit to mmguero-dev/Malcolm that referenced this issue Aug 15, 2024
@mmguero
idaholab#542 add 'public' pseudo-segment for source/destination publi…
de8d9af 
…c IP addresses
@mmguero
Copy link
Collaborator Author

mmguero commented Aug 15, 2024

Done. cross_segment tag is set, source.segment.name and/or destination.segment.name will be set to public when applicable.

@mmguero mmguero closed this as completed Aug 15, 2024
This was referenced Aug 20, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmguero mmguero

Labels
enhancement New feature or request logstash Relating to Malcolm's use of Logstash
Projects
Malcolm
Status: Released
Milestone
v24.08.0
Development

No branches or pull requests
1 participant
@mmguero