Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for reading from non-file steams #519

Closed
MicahGale opened this issue Aug 28, 2024 · 4 comments · Fixed by #520 or #553
Closed

Add support for reading from non-file steams #519

MicahGale opened this issue Aug 28, 2024 · 4 comments · Fixed by #520 or #553
Assignees
@MicahGale
Labels
feature request An issue that improves the user interface.

Comments

@MicahGale
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

It would be nice (mainly in testing) to do:

fh = io.StringIO()
fh.write(...)
fh.seek(0)
problem = montepy.read_input(fh)

Describe the solution you'd like
montepy.read_input should accept file streams.

Describe alternatives you've considered
None that I can think of.

Additional context
This is mostly for testing.
@MicahGale MicahGale added the feature request An issue that improves the user interface. label Aug 28, 2024
@MicahGale MicahGale self-assigned this Aug 28, 2024
@MicahGale MicahGale mentioned this issue Aug 28, 2024
Merged
12 tasks
@tjlaboss
Copy link
Collaborator

The soulmate of #493

@MicahGale
Copy link
Collaborator Author

☯️

@MicahGale
Copy link
Collaborator Author

Exactly. This is why I needed it.

@MicahGale MicahGale mentioned this issue Sep 11, 2024
Merged
@MicahGale MicahGale reopened this Sep 19, 2024
@MicahGale
Copy link
Collaborator Author

Turns out I forgot to implement this.

@MicahGale MicahGale mentioned this issue Sep 23, 2024
Merged
3 tasks
MicahGale added a commit that referenced this issue Sep 23, 2024
@MicahGale
Added #519 to changelog.
f851a6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MicahGale MicahGale

Labels
feature request An issue that improves the user interface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue with shortcut recompression idaholab/MontePy
Make a stream readable. idaholab/MontePy
2 participants
@MicahGale @tjlaboss