Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass changelog-test when no code is modified #439

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

tjlaboss
Copy link
Collaborator

@tjlaboss tjlaboss commented Jul 9, 2024

Description

Add some additional logic to check if any code in montepy/ was updated.

Todo: squash

Fixes #436

Checklist

  • I have tested the CI.

@tjlaboss tjlaboss linked an issue Jul 9, 2024 that may be closed by this pull request
@tjlaboss
Copy link
Collaborator Author

tjlaboss commented Jul 9, 2024

So far so good: changelog-test now passes when no code is modified.

@MicahGale MicahGale self-requested a review July 9, 2024 18:03
Improve string wrapping in docstring of wrap_string_for_mcnp()
…-to-disable-changelog-test' into 436-add-logic-to-ci-to-disable-changelog-test
@tjlaboss
Copy link
Collaborator Author

tjlaboss commented Jul 9, 2024

Changelog test now fails if something is modified in montepy/ and changelog.rst wasn't updated.

Copy link
Collaborator

@MicahGale MicahGale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We'll have to see on my branch if this works as expected when both have changed.

@MicahGale
Copy link
Collaborator

fix bad yaml in main.yml

I've been there... a lot

@tjlaboss tjlaboss merged commit 50daa80 into develop Jul 9, 2024
14 checks passed
@tjlaboss tjlaboss deleted the 436-add-logic-to-ci-to-disable-changelog-test branch July 9, 2024 19:49
@MicahGale MicahGale mentioned this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logic to CI to disable changelog test
2 participants