Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profiling and benckmarking #513

Merged
merged 11 commits into from
Aug 28, 2024
Merged

Add profiling and benckmarking #513

merged 11 commits into from
Aug 28, 2024

Conversation

MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Aug 27, 2024

Description

Adds:

  • A profiling step of pytest test suite
  • A profiling test with a difficult model
  • A benchmarking test with a difficult model.

The difficult model contains around 1,000 cells, surfaces, and materials. Each material has 92 nuclides. The actual model is utter non-sense, but is valid, and meant to stress the system. I think this model is big enough to stress the system and identify bottle necks without just being useless CPU thrashing.

Fixes #515

Checklist

  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Fix line overrun warnings.

@tjlaboss tjlaboss added the performance 🐌 Issues related to speed and memory label Aug 27, 2024
@MicahGale MicahGale marked this pull request as ready for review August 27, 2024 20:17
@MicahGale MicahGale self-assigned this Aug 27, 2024
@MicahGale
Copy link
Collaborator Author

This test failed with the benchmark being too slow: https://github.com/idaholab/MontePy/actions/runs/10584100119/job/29327558717

@MicahGale
Copy link
Collaborator Author

I do plan to squash this merge to add adding the big_model to the git history multiple times.

Copy link
Collaborator

@tjlaboss tjlaboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #518

@MicahGale MicahGale merged commit 884bba7 into develop Aug 28, 2024
15 checks passed
@MicahGale MicahGale deleted the profile branch August 28, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD performance 🐌 Issues related to speed and memory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement profiling and benchmarking
2 participants