Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made multi-format multi-resolution favicons. #554

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Made multi-format multi-resolution favicons. #554

merged 3 commits into from
Sep 24, 2024

Conversation

MicahGale
Copy link
Collaborator

Description

I noticed that on DuckDuckGo our favicon doesn't show up in the results page:

image

Looking into how Bing handles this (most of the backend for DuckDuckGo), this is because we only provide an SVG icon. This forum post recommends providing a PNG, and including it in the sitemap. I couldn't get it to work in the sitemap though, so I'm ignoring that, and SO doesn't say this is necessary.

Another SO thread recommends providing lots of options. I decided we should do most of those. I couldn't get inkscape to export ICO so I think we can just ignore IE support. The new extension does work in adding multiple favicon options:

image

It is intentionally ordered from best to worst options.

Checklist

  • I have performed a self-review of my own code

@MicahGale MicahGale added the documentation Improvements or additions to documentation label Sep 24, 2024
@MicahGale MicahGale self-assigned this Sep 24, 2024
Copy link
Collaborator

@tjlaboss tjlaboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a 32x32 ico. Add that to the docs and then we'll merge

@MicahGale
Copy link
Collaborator Author

I added a 32x32 ico. Add that to the docs and then we'll merge

Added!

@MicahGale MicahGale merged commit c529c66 into develop Sep 24, 2024
15 checks passed
@MicahGale MicahGale deleted the favicon branch September 24, 2024 15:26
@MicahGale MicahGale mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants