Made multi-format multi-resolution favicons. #554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that on DuckDuckGo our favicon doesn't show up in the results page:
Looking into how Bing handles this (most of the backend for DuckDuckGo), this is because we only provide an SVG icon. This forum post recommends providing a PNG, and including it in the sitemap. I couldn't get it to work in the sitemap though, so I'm ignoring that, and SO doesn't say this is necessary.
Another SO thread recommends providing lots of options. I decided we should do most of those. I couldn't get inkscape to export ICO so I think we can just ignore IE support. The new extension does work in adding multiple favicon options:
It is intentionally ordered from best to worst options.
Checklist