Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GapPerfectConductance from BISON to MOOSE #28963

Closed
gambka opened this issue Oct 29, 2024 · 0 comments · Fixed by #28982
Closed

Move GapPerfectConductance from BISON to MOOSE #28963

gambka opened this issue Oct 29, 2024 · 0 comments · Fixed by #28982
Labels
T: task An enhancement to the software.

Comments

@gambka
Copy link
Contributor

gambka commented Oct 29, 2024

Motivation

GapPerfectConductance is a type of thermal BC used in ThermalContact for non-mortar based contact. It enforces that perfect conductance occurs across the gap by setting the temperature equal on opposite sides of the gap. A penalty parameter, of a sufficiently high value, is required to lead to proper enforcement when in axisymmetric coordinates with small gap widths. Currently, GapPerfectConductance lives in the MOOSE-based app BISON and is almost always created via the ThermalContactAction. Unfortunately, the penalty parameter of the GapPErfectConductance cannot be currently set by the user through the ThermalContactAction. It also doesn't make sense to add the penalty parameter to the action that is housed in moose/modules/heat_transfer when it is only useable by an object in BISON. There is nothing in this model preventing its use in other applications.

Design

Move existing source, tests, and documentation from BISON to appropriate locations in moose/modules/heat_transfer. Add a new test for the small gap axisymmetric case demonstrating the need of the penalty parameter. A patch PR to BISON will be necessary and will be coordinated with the changes addressing this issue.

Impact

People can properly access all input parameters for GapPerfectConductance and appropriately set all input parameters via the input file through the ThermalContactAction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: task An enhancement to the software.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant