Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initializer list #25341

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Initializer list #25341

merged 1 commit into from
Aug 30, 2023

Conversation

dschwen
Copy link
Member

@dschwen dschwen commented Aug 29, 2023

Refs #24455

This is in preparation for @MengnanLi91 's PR that removes implicitly empty vector defaults for vector input parameters. This will allow users to specify empty vector defaults explicitly as {}.

@moosebuild
Copy link
Contributor

Job Documentation on e136bdc wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Coverage on e136bdc wanted to post the following:

Framework coverage

e5367e #25341 e136bd
Total Total +/- New
Rate 85.65% 85.65% +0.00% 75.00%
Hits 90369 90376 +7 6
Misses 15142 15140 -2 2

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

Warnings

  • framework new line coverage rate 75.00% is less than the suggested 90.0%

This comment will be updated on new commits.

@dschwen
Copy link
Member Author

dschwen commented Aug 30, 2023

Coverage is bogus

@GiudGiud
Copy link
Contributor

looks good thanks for the trick this will help downstream patches

@dschwen
Copy link
Member Author

dschwen commented Aug 30, 2023

What's the deal with the failing conda recipes?

@GiudGiud
Copy link
Contributor

do not know @milljm

@moosebuild
Copy link
Contributor

Job Conda MOOSE (Linux) on e136bdc : invalidated by @milljm

Cleared lock file.

@milljm
Copy link
Member

milljm commented Aug 30, 2023

Most likely was a network hiccup. If the process is interrupted (the long remote command ssh create lock file; do stuff; wait for stuff to finish; delete lock; exit) this is the result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants