Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add links to moosedocs tagging #25607

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Add links to moosedocs tagging #25607

merged 4 commits into from
Sep 28, 2023

Conversation

GiudGiud
Copy link
Contributor

@GiudGiud GiudGiud self-assigned this Sep 27, 2023
@GiudGiud GiudGiud marked this pull request as ready for review September 27, 2023 19:18
cticenhour
cticenhour reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@cticenhour cticenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An initial review, pending check of the rendered documentation as well.

python/MooseDocs/extensions/tagging.py Outdated Show resolved Hide resolved
python/MooseDocs/extensions/tagging.py Outdated Show resolved Hide resolved
python/MooseDocs/extensions/tagging.py Show resolved Hide resolved
@GiudGiud GiudGiud requested a review from cticenhour September 27, 2023 21:09
@moosebuild
Copy link
Contributor

moosebuild commented Sep 27, 2023 •
edited
Loading

Job Documentation on fc1018d wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Sep 27, 2023 •
edited
Loading

Job Coverage on fc1018d wanted to post the following:

Framework coverage

dcbdc8 #25607 fc1018
Total Total +/- New
Rate 85.68% 85.68% -0.00% -
Hits 91673 91669 -4 0
Misses 15318 15322 +4 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@GiudGiud
Copy link
Contributor Author

ah looks broken now
https://mooseframework.inl.gov/docs/PRs/25607/site/modules/electromagnetics/filter/index.html

@GiudGiud
Copy link
Contributor Author

GiudGiud commented Sep 27, 2023 •
edited
Loading

should be fixed

ugh the links require me to cut at content. This isnt great

@GiudGiud @cticenhour
Address Casey's review
fc1018d 
- better comments in python tagging code

Co-authored-by: Casey Icenhour <cticenhour@gmail.com>
@GiudGiud
Copy link
Contributor Author

Looks so good

Test failure unrelated

@cticenhour cticenhour merged commit e876aed into idaholab:next Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cticenhour cticenhour cticenhour approved these changes

Assignees

@GiudGiud GiudGiud

Labels
PR: Failed but allowed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GiudGiud @moosebuild @cticenhour