Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diffing capability to the listing extension #29007

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

loganharbour
Copy link
Member

@loganharbour loganharbour commented Nov 5, 2024

@loganharbour loganharbour marked this pull request as ready for review November 5, 2024 17:30
@loganharbour loganharbour requested a review from milljm November 5, 2024 17:30
@moosebuild
Copy link
Contributor

moosebuild commented Nov 5, 2024

Job Documentation, step Docs: sync website on de88f9d wanted to post the following:

View the site here

This comment will be updated on new commits.

@loganharbour
Copy link
Member Author

Looking for input on the naming here (the "Before" and "After"):

Screenshot 2024-11-05 at 12 49 58 PM

These are configurable, but it would be nice to have reasonable defaults

@loganharbour
Copy link
Member Author

loganharbour commented Nov 5, 2024

@joshuahansel gave the suggestion of -/+ for the link prefixes. I added this and think I like it:

image

@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on de88f9d wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@loganharbour
Copy link
Member Author

Failure are unrelated.

@loganharbour loganharbour merged commit 53b7f72 into idaholab:next Nov 6, 2024
49 of 51 checks passed
@loganharbour loganharbour deleted the 29002_listing_diff branch November 6, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to show text diff
3 participants