Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Restructure HybridModel class #1202

Closed
10 tasks done
wangcj05 opened this issue Apr 7, 2020 · 3 comments · Fixed by #1232
Closed
10 tasks done

[TASK] Restructure HybridModel class #1202

wangcj05 opened this issue Apr 7, 2020 · 3 comments · Fixed by #1232
Assignees
Labels
priority_minor task This tag should be used for any new capability, improvement or enanchment

Comments

@wangcj05
Copy link
Collaborator

wangcj05 commented Apr 7, 2020


Issue Description

A new model entity "LogicalModel" will be implemented. The LogicalModel utilizes control functions or fault tree/event tree to manage the selection and execution of different models (i.e. ExternalModel, ROMs, Codes). Both LogicalModel and current HybridModel share some common functionalities. In this case, a new base class will be created for both entities. First, we are planing to restructure the HybridModel entity, and create the base class for it. Second, after the restructure, the LogicalModel entity will be created. In addition, since HybridModel and EnsembleModel entities also share some common functionalities when interact with models. A common module to handle the interactions with models will also be created.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@wangcj05 wangcj05 added priority_minor task This tag should be used for any new capability, improvement or enanchment labels Apr 7, 2020
@wangcj05 wangcj05 assigned alfoa and wangcj05 and unassigned alfoa Apr 7, 2020
@wangcj05
Copy link
Collaborator Author

wangcj05 commented Apr 7, 2020

@alfoa @PaulTalbot-INL @mandd Please take a look at this issue, and all comments are really appreciated.

@wangcj05 wangcj05 mentioned this issue Apr 7, 2020
9 tasks
@PaulTalbot-INL
Copy link
Collaborator

This looks consistent with our team discussions to me. I like the idea of a "model handler helper" entity more than trying to build it into any of the base classes 👍

@alfoa
Copy link
Collaborator

alfoa commented May 28, 2020

Closure checklist passed...

Closure approved via #1232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority_minor task This tag should be used for any new capability, improvement or enanchment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants