Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEFECT] Conjiugate Gradient does not perform a line search #1493

Closed
5 of 10 tasks
alfoa opened this issue Apr 1, 2021 · 0 comments · Fixed by #1494
Closed
5 of 10 tasks

[DEFECT] Conjiugate Gradient does not perform a line search #1493

alfoa opened this issue Apr 1, 2021 · 0 comments · Fixed by #1494
Assignees
@PaulTalbot-INL @joshua-cogliati-inl @wangcj05 @alfoa @mandd
Labels
defect priority_normal

Comments

@alfoa
Copy link
Collaborator

alfoa commented Apr 1, 2021 •
edited
Loading

Defect Description

Describe the defect

What did you expect to see happen?

The conjugate gradient step strategy to change the step size depending on the solution history

What did you see instead?

The conjugate gradient does not correctly perform a line search (basically it is not doing what it is supposed to do). No step adaptivity is implemented

Do you have a suggested fix for the development team?

Describe how to Reproduce
Steps to reproduce the behavior:

  1. simply run a cj optimization

Screenshots and Input Files
Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

Platform (please complete the following information):

  • OS: [e.g. iOS]
  • Version: [e.g. 22]
  • Dependencies Installation: [CONDA or PIP]

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
alfoa added a commit that referenced this issue Apr 1, 2021
@alfoa
Closes #1493
924b55d
@alfoa alfoa mentioned this issue Apr 1, 2021
Merged
9 tasks
PaulTalbot-INL pushed a commit that referenced this issue Oct 13, 2021
@alfoa @aalfonsi
Closes #1493 - Fix Conjugated Gradient (#1494)
4c1a360 
* Closes #1493

* removed print statement

* minor other fixes

* restart civet

* Fixed issue #1520. Closes #1520

* Closes #1521

* Update plugin_handler.py

* Update GradientDescent.py

* Update step.tex

Co-authored-by: Andrea Alfonsi <andrea.alfonsi86@gmail.com>
wangcj05 pushed a commit that referenced this issue Oct 29, 2021
@aalfonsi @alfoa @Jimmy-INL
Failure with GA (#1677)
d9cd849 
* Closes #1493

* removed print statement

* minor other fixes

* restart civet

* Fixed issue #1520. Closes #1520

* Closes #1521

* fix

* Closes #1665

* Fixed GA failures in case of failures

* Update plugin_handler.py

* Update GradientDescent.py

* Update GradientDescent.py

* added failure

* Update GeneticAlgorithm.py

* Update MultiRun.py

added explanation

* Update failureOfRuns.xml

* for test

* making the failures random and adding the test to tests after regolding

* reverted files

* since the new ROM API, this pickled rom needed to be regenerated

* it seems that some of the user guide inputs did not get updated after ROM api update

* fixed Dataset


Co-authored-by: alfoa <andrea.alfonsi@inl.gov>
Co-authored-by: ANDREA ALFONSI <alfoa@ANDREAs-MacBook-Pro.local>
Co-authored-by: Jimmy-INL <52417034+Jimmy-INL@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PaulTalbot-INL PaulTalbot-INL

@joshua-cogliati-inl joshua-cogliati-inl

@wangcj05 wangcj05

@alfoa alfoa

@mandd mandd

Labels
defect priority_normal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #1493 - Fix Conjugated Gradient idaholab/raven
5 participants
@PaulTalbot-INL @joshua-cogliati-inl @wangcj05 @alfoa @mandd