Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outstreams Line Plot is not working correctly with unsync HistorySet #722

Closed
10 tasks done
wangcj05 opened this issue Aug 2, 2018 · 1 comment · Fixed by #725
Closed
10 tasks done

Outstreams Line Plot is not working correctly with unsync HistorySet #722

wangcj05 opened this issue Aug 2, 2018 · 1 comment · Fixed by #725
Assignees
@wangcj05
Labels
defect devel issues in current devel priority_normal

Comments

@wangcj05
Copy link
Collaborator

wangcj05 commented Aug 2, 2018 •
edited by alfoa
Loading

Issue Description

What did you expect to see happen?

The plots should be continuous.

What did you see instead?

to_plot_line

Do you have a suggested fix for the development team?
Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or improvement?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest stable branch? If yes, is there any issue tagged with stable (create if needed)?
  • 5. If the issue is being closed without a merge request, has an explanation of why it is being closed been provided?
@wangcj05 wangcj05 self-assigned this Aug 2, 2018
wangcj05 added a commit that referenced this issue Aug 2, 2018
@wangcj05
fix issue #722, and add a test
56ea34e
@wangcj05 wangcj05 mentioned this issue Aug 2, 2018
Merged
8 tasks
@alfoa
Copy link
Collaborator

alfoa commented Aug 3, 2018

No wrong results are possible but just a bad visualization.

No email required.

closure checklist passed...

@alfoa alfoa added the devel issues in current devel label Aug 3, 2018
@alfoa alfoa closed this as completed in #725 Aug 3, 2018
alfoa pushed a commit that referenced this issue Aug 3, 2018
@wangcj05 @alfoa
Fix OutStreams Line Plot. (#725)
b964a0c 
* fix issue #722, and add a test

* resolve comments

* fix xml validation

* update test
@alfoa alfoa mentioned this issue May 9, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wangcj05 wangcj05

Labels
defect devel issues in current devel priority_normal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix OutStreams Line Plot. idaholab/raven
2 participants
@wangcj05 @alfoa