-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit Surface bounding error #1217
Conversation
Job Mingw Test on 440caa1 : invalidated by @alfoa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments.
tests/framework/PostProcessors/LimitSurface/test_LimitSurface_with_err_bounds.xml
Outdated
Show resolved
Hide resolved
This PR adds a new requirement. |
@wangcj05 I had to modify the way to compute the error bound (Actually just the perturbation on one of the sides of the LS...). The previous approach was not stable since it was not considering the magnitude of the FOM of interest. |
Checklist is satisfied, and this PR can be merged. |
@alfoa Do you want to delete your branch? |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #1216
What are the significant changes in functionality due to this change request?
This PR adds the optional possibility to estimate the bounding error of the limit surface integral.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.