Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Surface bounding error #1217

Merged
merged 15 commits into from
Apr 23, 2020
Merged

Limit Surface bounding error #1217

merged 15 commits into from
Apr 23, 2020

Conversation

alfoa
Copy link
Collaborator

@alfoa alfoa commented Apr 16, 2020


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #1216

What are the significant changes in functionality due to this change request?

This PR adds the optional possibility to estimate the bounding error of the limit surface integral.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@alfoa alfoa requested a review from wangcj05 April 16, 2020 04:56
@moosebuild
Copy link

Job Mingw Test on 440caa1 : invalidated by @alfoa

Copy link
Collaborator

@wangcj05 wangcj05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

doc/user_manual/postprocessor.tex Outdated Show resolved Hide resolved
doc/user_manual/postprocessor.tex Outdated Show resolved Hide resolved
framework/PostProcessors/LimitSurfaceIntegral.py Outdated Show resolved Hide resolved
@alfoa
Copy link
Collaborator Author

alfoa commented Apr 17, 2020

This PR adds a new requirement.
As chair of the COB, I approve such addition.

@alfoa
Copy link
Collaborator Author

alfoa commented Apr 21, 2020

@wangcj05 I had to modify the way to compute the error bound (Actually just the perturbation on one of the sides of the LS...). The previous approach was not stable since it was not considering the magnitude of the FOM of interest.

@wangcj05
Copy link
Collaborator

Checklist is satisfied, and this PR can be merged.

@wangcj05 wangcj05 merged commit 779ce69 into devel Apr 23, 2020
@wangcj05
Copy link
Collaborator

@alfoa Do you want to delete your branch?

@alfoa alfoa deleted the alfoa/ls_error_bounds branch May 6, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Limit Surface Integral Bounding Error
3 participants