Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heron submod #1236

Merged
merged 6 commits into from
May 15, 2020
Merged

Heron submod #1236

merged 6 commits into from
May 15, 2020

Conversation

PaulTalbot-INL
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL commented May 13, 2020


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #1129

What are the significant changes in functionality due to this change request?

Adds HERON as a supported submodule of RAVEN, available for those with access to it.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@PaulTalbot-INL PaulTalbot-INL requested a review from alfoa May 13, 2020 14:57
@PaulTalbot-INL PaulTalbot-INL mentioned this pull request May 13, 2020
9 tasks
@moosebuild
Copy link

Job Mingw Test on dc8c91a : invalidated by @joshua-cogliati-inl

restarted civet

1 similar comment
@moosebuild
Copy link

Job Mingw Test on dc8c91a : invalidated by @joshua-cogliati-inl

restarted civet

@moosebuild
Copy link

Job Mingw Test on dc8c91a : invalidated by @joshua-cogliati-inl

checking civet.

@moosebuild
Copy link

Job Mingw Test on dc8c91a : invalidated by @joshua-cogliati-inl

restarted civet

1 similar comment
@moosebuild
Copy link

Job Mingw Test on dc8c91a : invalidated by @joshua-cogliati-inl

restarted civet

@alfoa alfoa added the RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 label May 13, 2020
@alfoa
Copy link
Collaborator

alfoa commented May 13, 2020

Can you update issue #1225? I know it is tedious but we did not implement an automatic system yet.

@PaulTalbot-INL
Copy link
Collaborator Author

Updated

@alfoa
Copy link
Collaborator

alfoa commented May 15, 2020

Checklist passed...

PR can be accepted...

As chair of the Control Board, I approve the addition of a new official plugin.

@alfoa alfoa mentioned this pull request May 15, 2020
10 tasks
@alfoa alfoa merged commit b2d755a into idaholab:devel May 15, 2020
@alfoa alfoa deleted the heron_submod branch May 15, 2020 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RAVENv2.1 All tasks and defects that will go in RAVEN v2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Add HERON as RAVEN submodule
3 participants