Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HERON plugin #1271

Merged
merged 24 commits into from
Jul 22, 2020
Merged

HERON plugin #1271

merged 24 commits into from
Jul 22, 2020

Conversation

PaulTalbot-INL
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL commented Jul 10, 2020


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #1270
See #1114

What are the significant changes in functionality due to this change request?

Adds HERON as an official RAVEN plugin.

Also extends the library dependency system to use XML instead of INI files, due to the complexity required.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@PaulTalbot-INL
Copy link
Collaborator Author

I found a bug with the Tester that was letting tests pass on a local machine if they passed before. Working on a fix ...

@moosebuild
Copy link

Job Mingw Test on 31cac93 : invalidated by @alfoa

@PaulTalbot-INL
Copy link
Collaborator Author

I still need to push a change in the HERON version to keep up with the XML dependency change, but I can't access the hpclogin node right now.

@moosebuild
Copy link

Job Mingw Test on bc6f282 : canceled by @PaulTalbot-INL

Windows not checking out submodules successfully; canceling for now.

@PaulTalbot-INL PaulTalbot-INL requested a review from alfoa July 22, 2020 15:37
@alfoa alfoa mentioned this pull request Jul 22, 2020
10 tasks
@alfoa
Copy link
Collaborator

alfoa commented Jul 22, 2020

@PaulTalbot-INL can you update the floating issues about the main features that will go in RAVEN 2.1?

@alfoa
Copy link
Collaborator

alfoa commented Jul 22, 2020

Checklist passed...

PR approve and can be merged..

@alfoa alfoa added the RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 label Jul 22, 2020
@alfoa alfoa merged commit ee68b4a into idaholab:devel Jul 22, 2020
@PaulTalbot-INL PaulTalbot-INL deleted the heron_submod branch April 8, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RAVENv2.1 All tasks and defects that will go in RAVEN v2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] HERON as official RAVEN plugin
3 participants