Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to sign the .so files. #1362

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Adding ability to sign the .so files. #1362

merged 1 commit into from
Nov 3, 2020

Conversation

joshua-cogliati-inl
Copy link
Contributor

@joshua-cogliati-inl joshua-cogliati-inl commented Oct 30, 2020


Pull Request Description

What issue does this change request address?

closes #1361

What are the significant changes in functionality due to this change request?

Adds a variable to the .ravenrc with the signature to use and then if that is present, will sign the .so modules produced as part of the build.

This will probably be needed in future mac os releases.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

This will be needed in future mac os releases.
@joshua-cogliati-inl
Copy link
Contributor Author

joshua-cogliati-inl commented Nov 2, 2020

Suggested addition to wiki when this is accepted:

Library issues on MacOS

Depending on security settings, the python binary libraries might need to be signed on MacOS. If this is the problem, the .so files are created, but they cannot be loaded. A self signed certificate can be created by following instructions in https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html and then the name of it can be added to the .ravenrc file (for example: RAVEN_SIGNATURE = John Doe ) Then when build_raven is run it will sign the compiled binary files.

Copy link
Collaborator

@alfoa alfoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@alfoa
Copy link
Collaborator

alfoa commented Nov 3, 2020

Checklist passed...

@joshua-cogliati-inl please update the wiki and add a link in the MAC installation page

@alfoa
Copy link
Collaborator

alfoa commented Nov 3, 2020

Checklist passed.... Merging

@alfoa alfoa merged commit 363dd17 into devel Nov 3, 2020
@alfoa alfoa deleted the cogljj/sign_so branch November 3, 2020 23:27
alfoa pushed a commit that referenced this pull request Nov 19, 2020
* Adding ability to sign the .so files. (#1362)

Adding ability to sign the .so files.. This will be needed in future mac os releases.

* debug

* fix dymolainterface

* revert code interface changes

* update rounding error for time index

* fix index for duplicated values

Co-authored-by: Joshua J. Cogliati <joshua-cogliati-inl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Support macOS code signing as part of build
2 participants