Handling Constraints using feasibleFirst parameterless fitness #1455

Jimmy-INL · 2021-03-03T18:50:09Z

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

closes #1454 1454

What are the significant changes in functionality due to this change request?

enabling constraint handling in GA

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

1. Review all computer code.
2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
8. If an analytic test is changed/added is the the analytic documentation updated/added?
9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

moosebuild · 2021-03-03T21:32:02Z

Job Test mac on d1508d2 : invalidated by @Jimmy-INL

moosebuild · 2021-03-04T21:16:09Z

Job Mingw Test on 2518466 : invalidated by @Jimmy-INL

moosebuild · 2021-03-06T16:44:31Z

Job Mingw Test on 336d7cd : invalidated by @Jimmy-INL

moosebuild · 2021-03-06T19:22:48Z

Job Mingw Test on 91314f3 : invalidated by @Jimmy-INL

moosebuild · 2021-03-07T04:51:41Z

Job Mingw Test on 086516c : invalidated by @Jimmy-INL

alfoa · 2021-04-05T22:09:23Z

@Jimmy-INL is this reviewable?

Jimmy-INL · 2021-04-05T22:13:08Z

Yes. Most of the files are tests so please do not panic. Mohammad G. Abdo, Ph.D. Modeling and Simulation Scientist | Digital Reactor Technology and Development (C160) Reactor Systems Design and Analysis | NS&T ***@***.******@***.***> | REC EROB IF-654 3EM402 | Phone: 208-526-4640 Idaho National Laboratory | 2525 Fremont Ave. | Idaho Falls, ID | 83415 [6GC4jc7QCCEAAAAASUVORK5CYII=]<https://www.linkedin.com/in/mohammad-abdo-a7625082/>. [PXly9OZ1PK9LcRv4PSG3pAb9jevQAAAAASUVORK5CYII=] <https://www.researchgate.net/profile/Mohammad_Abdo/research> [RPr5ytnPx9Cc691m9I+4T+nIo7v4HxgxndxMwKP8AAAAASUVORK5CYII=] <https://github.com/Jimmy-INL>

…

___________________________________ [wYtJH347IiIiAYVYS1skEvgxC4KpkYRTFRBbsT51peEIp5j0ExRuvWouzr1J+za4DYirM+SlQmTZXUTsvjtVtouILWngWSxC+xJbAP86Fg5oVmy2ERH1w38A8nnHfeT8na8AAAAASUVORK5CYII=] From: Andrea Alfonsi - INL ***@***.***> Date: Monday, April 5, 2021 at 4:09 PM To: idaholab/raven ***@***.***> Cc: Mohammad G. Abdo ***@***.***>, Mention ***@***.***> Subject: [EXTERNAL] Re: [idaholab/raven] Handling Constraints using feasibleFirst parameterless fitness (#1455) @Jimmy-INL<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgh.neting.cc%2FJimmy-INL&data=04%7C01%7Cmohammad.abdo%40inl.gov%7Cd4a065a925d342d5a05608d8f87f8057%7C4cf464b7869a42368da2a98566485554%7C0%7C0%7C637532573783408721%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ZQtTfPnLBWHjUkz9uy1tqKEaUcSGobbjuezXz9XFKGI%3D&reserved=0> is this reviewable? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgh.neting.cc%2Fidaholab%2Fraven%2Fpull%2F1455%23issuecomment-813678850&data=04%7C01%7Cmohammad.abdo%40inl.gov%7Cd4a065a925d342d5a05608d8f87f8057%7C4cf464b7869a42368da2a98566485554%7C0%7C0%7C637532573783408721%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=NMwGHLxZW4vtUJQPIxAXMLqBQ7fOf%2BKs1TV0V9l%2BrZs%3D&reserved=0>, or unsubscribe<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgh.neting.cc%2Fnotifications%2Funsubscribe-auth%2FAMP5ECVD2XSVPDX5QZSLLHTTHIYKBANCNFSM4YRYXZVA&data=04%7C01%7Cmohammad.abdo%40inl.gov%7Cd4a065a925d342d5a05608d8f87f8057%7C4cf464b7869a42368da2a98566485554%7C0%7C0%7C637532573783418675%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=syNpjSjo0VBdunR26YAOyUzZt9PMTymQyCjxN7Qolxo%3D&reserved=0>.

framework/Optimizers/GeneticAlgorithm.py

tests/framework/AnalyticModels/optimizing/offset_parabola_GA2.py

tests/framework/AnalyticModels/optimizing/rosenbrockCubicConstrained1.py

tests/framework/AnalyticModels/optimizing/rosenbrockCubicConstrained2.py

tests/framework/AnalyticModels/optimizing/simionescuConstrained.py

...ramework/Optimizers/GeneticAlgorithms/continuous/constrained/testGAMishraBirdConstrained.xml

aalfonsi · 2021-05-26T02:48:19Z

@Jimmy-INL can you fix the conflicts ?

moosebuild · 2021-05-26T20:40:10Z

Job Mingw Test on 45132cd : invalidated by @Jimmy-INL

moosebuild · 2021-05-27T01:07:32Z

Job Mingw Test on 45132cd : invalidated by @Jimmy-INL

moosebuild · 2021-05-27T02:49:34Z

Job Test Ubuntu 18 PIP on 45132cd : invalidated by @Jimmy-INL

moosebuild · 2021-05-27T21:31:55Z

Job Mingw Test on 45132cd : invalidated by @joshua-cogliati-inl

checking civet.

moosebuild · 2021-05-27T21:33:02Z

Job Mingw Test on 45132cd : invalidated by @joshua-cogliati-inl

checking civet.

moosebuild · 2021-05-27T21:35:34Z

Job Mingw Test on 45132cd : invalidated by @joshua-cogliati-inl

checking civet.

joshua-cogliati-inl

One place has a unordered dictionary that might be causing differences.

framework/utils/gaUtils.py

joshua-cogliati-inl · 2021-06-02T14:22:08Z

Hm, I don't see any other obvious uses of unordered dictionaries.
I suppose you could try:
<python skip_check='True'>3.7</python>
in dependencies.xml

joshua-cogliati-inl · 2021-06-02T14:30:12Z

Hm, looking at the results, what is happening with x and y in tests/framework/Optimizers/GeneticAlgorithms/continuous/constrained/rosenbrockCubicandLineConstrained/opt_export_0.csv?:

  Different values in x for -0.95568497606 and -0.0469615763395
  Different values in y for 0.95303842366 and 0.0443150239401
  Different values in ans for 3.98234965029 and 1.27345067232
  Different values in fitness for -3.98234965029 and -1.27345067232
  Different values in x for -0.0469615763395 and -0.95568497606
  Different values in y for 0.0443150239401 and 0.95303842366
  Different values in ans for 1.27345067232 and 3.98234965029
  Different values in fitness for -1.27345067232 and -3.98234965029
  Different values in x for -0.95568497606 and -0.0469615763395
  Different values in y for 0.95303842366 and 0.0443150239401
  Different values in ans for 3.98234965029 and 1.27345067232
  Different values in fitness for -3.98234965029 and -1.27345067232
  Different values in x for -0.0469615763395 and -0.95568497606
  Different values in y for 0.0443150239401 and 0.95303842366
  Different values in ans for 1.27345067232 and 3.98234965029
  Different values in fitness for -1.27345067232 and -3.98234965029
  Different values in x for -0.0469615763395 and -0.95568497606
  Different values in y for 0.0443150239401 and 0.95303842366
  Different values in ans for 1.27345067232 and 3.98234965029
  Different values in fitness for -1.27345067232 and -3.98234965029

joshua-cogliati-inl · 2021-06-02T14:32:20Z

It would also be worth trying using the unordered csv checker instead of the ordered csv.

tests/framework/Optimizers/GeneticAlgorithms/tests

moosebuild · 2021-06-11T02:22:44Z

Job Test mac on 9ed8de9 : invalidated by @Jimmy-INL

moosebuild · 2021-07-07T20:16:50Z

Job Test Ubuntu 16 on bc82bc4 : invalidated by @mandd

moosebuild · 2021-07-07T21:03:35Z

Job Test qsubs on bc82bc4 : invalidated by @mandd

…hub.com/idaholab/raven into alfoa/mandd/Jimmy-GA-ConstraintHandling

moosebuild · 2021-07-08T01:50:49Z

Job Test qsubs on 52d53cd : invalidated by @aalfonsi

moosebuild · 2021-07-08T01:51:17Z

Job Test Ubuntu 18-2 Python 3 on 52d53cd : invalidated by @aalfonsi

framework/Optimizers/GeneticAlgorithm.py

mandd · 2021-07-08T21:15:05Z

Are we ready for merging this PR?

wangcj05

I have provided couple of comments for your consideration. In addition:

please try to answer all reviewers' comments, even if we have discussed in person
Please remove png files, I think you do not check the difference between png files, but just check the existence, right?

...ramework/Optimizers/GeneticAlgorithms/continuous/constrained/testGAMishraBirdConstrained.xml

...ptimizers/GeneticAlgorithms/continuous/constrained/testGARosenbrockDiskConstrainedInvLin.xml

...rk/Optimizers/GeneticAlgorithms/continuous/constrained/testGAMishraBirdConstrainedInvLin.xml

.../framework/Optimizers/GeneticAlgorithms/continuous/constrained/testGATownsendConstrained.xml

wangcj05 · 2021-07-08T22:05:29Z

Are we ready for merging this PR?

wangcj05 · 2021-07-08T22:08:23Z

@mandd I have couple of comments for this PR.
@Jimmy-INL I sorry, I just accidentally closed this PR

moosebuild · 2021-07-09T15:30:13Z

Job Test Ubuntu 18-2 Python 3 on 8a50404 : invalidated by @mandd

aalfonsi · 2021-07-11T04:49:03Z

Can we merge this?

@alfoa

@alfoa is changed to @aalfonsi

wangcj05 · 2021-07-11T17:41:54Z

Changes are good, and checklist is satisfied.

wangcj05 · 2021-07-11T17:43:00Z

@Jimmy-INL @mandd @aalfonsi FYI. I have merged this PR. Thanks @Jimmy-INL and @mandd.

Jimmy-INL added priority_critical task This tag should be used for any new capability, improvement or enanchment RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 labels Mar 3, 2021

Jimmy-INL added this to the Genetic Algorithms Basic Initial Deployment milestone Mar 3, 2021

Jimmy-INL changed the title ~~[WIP] Handling Constraints using feasibleFirst parameterless fitness~~ Handling Constraints using feasibleFirst parameterless fitness Mar 3, 2021

Jimmy-INL added the Do Not Merge label Mar 5, 2021

Jimmy-INL requested review from mandd and aalfonsi March 8, 2021 15:57

Jimmy-INL removed the Do Not Merge label Mar 15, 2021

alfoa previously requested changes Apr 11, 2021

View reviewed changes

joshua-cogliati-inl reviewed Jun 1, 2021

View reviewed changes

framework/utils/gaUtils.py Outdated Show resolved Hide resolved

joshua-cogliati-inl reviewed Jun 2, 2021

View reviewed changes

tests/framework/Optimizers/GeneticAlgorithms/tests Show resolved Hide resolved

Jimmy-INL added 2 commits July 7, 2021 18:17

removing unnecessary comment in test

c3a19d0

Merge branch 'alfoa/mandd/Jimmy-GA-ConstraintHandling' of https://git…

52d53cd

…hub.com/idaholab/raven into alfoa/mandd/Jimmy-GA-ConstraintHandling

fixing dockstring

db941f3

aalfonsi reviewed Jul 8, 2021

View reviewed changes

framework/Optimizers/GeneticAlgorithm.py Outdated Show resolved Hide resolved

removing redundunt term in fitness equation

0f9f055

wangcj05 requested changes Jul 8, 2021

View reviewed changes

wangcj05 closed this Jul 8, 2021

wangcj05 reopened this Jul 8, 2021

updating tests names

05613e3

mandd mentioned this pull request Jul 8, 2021

cleaning GAs #1604

Merged

9 tasks

Jimmy-INL and others added 3 commits July 8, 2021 20:41

fixing names and descriptions of tests

0f6567d

removing png from gold

ff9016f

fixed xml file

8a50404

fixed test file

280e4aa

wangcj05 approved these changes Jul 11, 2021

View reviewed changes

wangcj05 removed the request for review from alfoa July 11, 2021 17:36

wangcj05 merged commit 99bed4b into devel Jul 11, 2021

wangcj05 deleted the alfoa/mandd/Jimmy-GA-ConstraintHandling branch July 11, 2021 17:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handling Constraints using feasibleFirst parameterless fitness #1455

Handling Constraints using feasibleFirst parameterless fitness #1455

Jimmy-INL commented Mar 3, 2021 •

edited by wangcj05

Loading

moosebuild commented Mar 3, 2021

moosebuild commented Mar 4, 2021

moosebuild commented Mar 6, 2021

moosebuild commented Mar 6, 2021

moosebuild commented Mar 7, 2021

alfoa commented Apr 5, 2021

Jimmy-INL commented Apr 5, 2021 via email

aalfonsi commented May 26, 2021

moosebuild commented May 26, 2021

moosebuild commented May 27, 2021

moosebuild commented May 27, 2021

moosebuild commented May 27, 2021

moosebuild commented May 27, 2021

moosebuild commented May 27, 2021

joshua-cogliati-inl left a comment

joshua-cogliati-inl commented Jun 2, 2021

joshua-cogliati-inl commented Jun 2, 2021 •

edited

Loading

joshua-cogliati-inl commented Jun 2, 2021

moosebuild commented Jun 11, 2021

moosebuild commented Jul 7, 2021

moosebuild commented Jul 7, 2021

moosebuild commented Jul 8, 2021

moosebuild commented Jul 8, 2021

mandd commented Jul 8, 2021

wangcj05 left a comment

wangcj05 commented Jul 8, 2021

wangcj05 commented Jul 8, 2021

moosebuild commented Jul 9, 2021

aalfonsi commented Jul 11, 2021

wangcj05 commented Jul 11, 2021

wangcj05 commented Jul 11, 2021

Handling Constraints using feasibleFirst parameterless fitness #1455

Handling Constraints using feasibleFirst parameterless fitness #1455

Conversation

Jimmy-INL commented Mar 3, 2021 • edited by wangcj05 Loading

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

moosebuild commented Mar 3, 2021

moosebuild commented Mar 4, 2021

moosebuild commented Mar 6, 2021

moosebuild commented Mar 6, 2021

moosebuild commented Mar 7, 2021

alfoa commented Apr 5, 2021

Jimmy-INL commented Apr 5, 2021 via email

aalfonsi commented May 26, 2021

moosebuild commented May 26, 2021

moosebuild commented May 27, 2021

moosebuild commented May 27, 2021

moosebuild commented May 27, 2021

moosebuild commented May 27, 2021

moosebuild commented May 27, 2021

joshua-cogliati-inl left a comment

Choose a reason for hiding this comment

joshua-cogliati-inl commented Jun 2, 2021

joshua-cogliati-inl commented Jun 2, 2021 • edited Loading

joshua-cogliati-inl commented Jun 2, 2021

moosebuild commented Jun 11, 2021

moosebuild commented Jul 7, 2021

moosebuild commented Jul 7, 2021

moosebuild commented Jul 8, 2021

moosebuild commented Jul 8, 2021

mandd commented Jul 8, 2021

wangcj05 left a comment

Choose a reason for hiding this comment

wangcj05 commented Jul 8, 2021

wangcj05 commented Jul 8, 2021

moosebuild commented Jul 9, 2021

aalfonsi commented Jul 11, 2021

wangcj05 commented Jul 11, 2021

wangcj05 commented Jul 11, 2021

Jimmy-INL commented Mar 3, 2021 •

edited by wangcj05

Loading

joshua-cogliati-inl commented Jun 2, 2021 •

edited

Loading