Standardize collectOutput method for PostProcessor #1471
Conversation
|
Job Mingw Test on 792e778 : invalidated by @wangcj05 Catastrophic error while removing repository. Exiting... |
|
Job Mingw Test on a83f076 : invalidated by @wangcj05 fetch issue |
| @@ -74,6 +74,8 @@ def __init__(self, runInfoDict): | |||
| self.mapping = {} # dictionary for mapping input space between different DataObjects {'variableName':'externalFunctionName'} | |||
| self.funcDict = {} # Contains the function to be used {'variableName':externalFunctionInstance} | |||
| self.label = None # ID of the variable which containf the label values | |||
| self.outputMultipleRealizations = True # True indicate multiple realizations are returned | |||
There was a problem hiding this comment.
is this variable being used?
There was a problem hiding this comment.
Yes, this is used to indicate what kind of method will be used to collect the output into the DataObjects. Currently, we have addRealization for single realization, and load method for multiple realizations.
| @ In, output, object, the object where we want to place our computed results | ||
| @ In, options, dict, optional, not used in PostProcessor. |
There was a problem hiding this comment.
should we specify it since PP doesn't use it?
There was a problem hiding this comment.
It inherits from the Model base class.
|
|
||
| # use BaseClass method provideExpectedMetaKeys and addMetaKeys to provide and modify metadata | ||
| self.outputDataset = False # True if the user wants to dump the outputs to dataset | ||
| self.validDataType = ['PointSet','HistorySet'] # The list of accepted types of DataObject |
There was a problem hiding this comment.
In most of our PP, we only allow PointSet and HistorySet. In each specific PP, we can specific the accepted types.
|
PR is good to me. Merging. |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
see #1451
Standardize the collectOutput method for PostProcessors. In ideal case, all PostProcessors should call the collectOutput method from the PostProcessor Base class, and there is no need for the PostProcessor to implement its own collectOutput method. This will simplify the PostProcessors when there is a standard way to pass and retrieve data from PostProcessors.
What are the significant changes in functionality due to this change request?
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>to True.raven/tests/framework/user_guideandraven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.