Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Interface PostProcessors #1533

Merged
merged 58 commits into from
May 12, 2021
Merged

Restructure Interface PostProcessors #1533

merged 58 commits into from
May 12, 2021

Conversation

wangcj05
Copy link
Collaborator

@wangcj05 wangcj05 commented Apr 29, 2021


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

close #1545
Change the Interface PostProcessor inheritance to follow the new RAVEN entity/interface structure.

Update TEAL and SR2ML submodule ID (see issue #1114)

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@wangcj05 wangcj05 changed the title Use xarray dataset for HS2PS post processor Restructure Interface PostProcessors May 7, 2021
@wangcj05 wangcj05 requested review from alfoa and mandd May 7, 2021 22:43
# self.transformationSettings['timeAxis'] = data[self.pivotParameter][0]
# self.transformationSettings['dimID'] = list(outDataset.keys())
# return outDataset
#########
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataMining are using several interfaced postprocessors as pre-processors. In order to make the DataMining test green, we need to convert these post processors to use Dataset at the same time. I have reverted the changes here, and I am proposing to work on this issue in next pull request, since there is already a lot of file changes in PR, and the conversion will take longer time than I thought.

mandd
mandd previously approved these changes May 10, 2021
@alfoa
Copy link
Collaborator

alfoa commented May 10, 2021

@wangcj05 you are updating 2 sub-modules...is that wanted? If so, please ref to the relative issue

@wangcj05
Copy link
Collaborator Author

@wangcj05 you are updating 2 sub-modules...is that wanted? If so, please ref to the relative issue

I have referenced the issue.

alfoa
alfoa previously approved these changes May 11, 2021
@alfoa alfoa added the RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 label May 11, 2021
@alfoa
Copy link
Collaborator

alfoa commented May 11, 2021

Checklist passed (waiting for tests)...

Merge approved by CCB Chair (me)...

Waiting for the tests to pass and then I will merge it...

@alfoa
Copy link
Collaborator

alfoa commented May 11, 2021

@wangcj05 failure on QSUB?

@moosebuild
Copy link

Job Test qsubs on 00db572 : invalidated by @wangcj05

Files not created: tests/cluster_tests/RavenRunsRaven/Rom/testPrintHistorySet_dump_14.csv (do not know the reason, rerun)

@moosebuild
Copy link

Job Test qsubs on 00db572 : invalidated by @wangcj05

qsub test raven run raven rom failed.

@alfoa alfoa merged commit 09fadae into devel May 12, 2021
@alfoa alfoa deleted the wangc/pp_dataset branch May 12, 2021 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RAVENv2.1 All tasks and defects that will go in RAVEN v2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Restructure Interface PostProcessor
4 participants