-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure Interface PostProcessors #1533
Conversation
# self.transformationSettings['timeAxis'] = data[self.pivotParameter][0] | ||
# self.transformationSettings['dimID'] = list(outDataset.keys()) | ||
# return outDataset | ||
######### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DataMining are using several interfaced postprocessors as pre-processors. In order to make the DataMining test green, we need to convert these post processors to use Dataset at the same time. I have reverted the changes here, and I am proposing to work on this issue in next pull request, since there is already a lot of file changes in PR, and the conversion will take longer time than I thought.
@wangcj05 you are updating 2 sub-modules...is that wanted? If so, please ref to the relative issue |
I have referenced the issue. |
Checklist passed (waiting for tests)... Merge approved by CCB Chair (me)... Waiting for the tests to pass and then I will merge it... |
@wangcj05 failure on QSUB? |
Job Test qsubs on 00db572 : invalidated by @wangcj05 Files not created: tests/cluster_tests/RavenRunsRaven/Rom/testPrintHistorySet_dump_14.csv (do not know the reason, rerun) |
Job Test qsubs on 00db572 : invalidated by @wangcj05 qsub test raven run raven rom failed. |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
close #1545
Change the Interface PostProcessor inheritance to follow the new RAVEN entity/interface structure.
Update TEAL and SR2ML submodule ID (see issue #1114)
What are the significant changes in functionality due to this change request?
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.