Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get-set state bypass for external ROM loader #1560

Merged
merged 2 commits into from
May 18, 2021

Conversation

PaulTalbot-INL
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL commented May 17, 2021


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #1559

What are the significant changes in functionality due to this change request?

Allows the external ROM loader to serialize regardless of the ROM it carries.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@PaulTalbot-INL PaulTalbot-INL requested a review from alfoa May 17, 2021 22:27
alfoa
alfoa previously approved these changes May 18, 2021
@moosebuild
Copy link

Job Test mac on 851a77b : invalidated by @alfoa

@PaulTalbot-INL
Copy link
Collaborator Author

Oops used dill to try something and didn't change back to cloud pickle. Will fix shortly.

@alfoa
Copy link
Collaborator

alfoa commented May 18, 2021

PR is approved once the dill modification is reverted.

@alfoa
Copy link
Collaborator

alfoa commented May 18, 2021

Checklist passed...

Test OpenSUSE Leap 15 is still not functioning but the tests on all the other linux machines pass.

@alfoa
Copy link
Collaborator

alfoa commented May 18, 2021

PR Approved.

Merging...

@alfoa alfoa merged commit 86046c1 into idaholab:devel May 18, 2021
@alfoa alfoa deleted the pk_romloader branch May 18, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Serialize externalROMloader instances
3 participants