Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClearRunDir must be set to False if interfaceCheck is activated #1689

Merged
merged 17 commits into from
Oct 25, 2021

Conversation

aalfonsi
Copy link
Collaborator

@aalfonsi aalfonsi commented Oct 21, 2021


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #1688

What are the significant changes in functionality due to this change request?

This is using the same functionality is used in the CodeInterfaceBase class (environment variable) to decide
if the clearRunDir must be set to False automatically


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@aalfonsi aalfonsi requested review from wangcj05 and mandd October 21, 2021 15:04
@moosebuild
Copy link

Job Test mac on 38c8a7d : invalidated by @aalfonsi

1 similar comment
@moosebuild
Copy link

Job Test mac on 38c8a7d : invalidated by @aalfonsi

Copy link
Collaborator

@wangcj05 wangcj05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are good.

@moosebuild
Copy link

Job Test mac on 38c8a7d : invalidated by @wangcj05

fetch issue

@wangcj05
Copy link
Collaborator

Changes are good, and checklist is satisfied. PR can be merged.

@wangcj05 wangcj05 merged commit 6b758ad into devel Oct 25, 2021
@wangcj05 wangcj05 deleted the alfonsi/clearRunDirTooNotInInterfaceCheck branch October 25, 2021 16:45
@wangcj05
Copy link
Collaborator

@aalfonsi Thanks for your contribution, and I have merged your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] clearRunDir in case of interfaceCheck
3 participants