Adding a KerasMLPRegression class to go with the KerasMLPClassifier. #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -145,7 +151,6 @@ def evaluate(self,edict): | |||
| featureValuesShape = fval.shape | |||
| if featureValuesShape != fval.shape: | |||
| self.raiseAnError(IOError,'In training set, the number of values provided for feature '+feat+' are not consistent to other features!') | |||
| self._localNormalizeData(values,names,feat) | |||
There was a problem hiding this comment.
This was a bug since it changed the normalization constants based on the evaluation data.
This allows regression to be done for non-timeseries data.
joshua-cogliati-inl
force-pushed
the
cogljj/keras_regression
branch
from
fb91e1e to
b0dc43a
Compare
|
Job Test qsubs sawtooth on bb34c45 : invalidated by @joshua-cogliati-inl Testing server removal of raven_libraries |
|
Job Test qsubs sawtooth on bb34c45 : invalidated by @joshua-cogliati-inl changed civet recipe |
aalfonsi
approved these changes
Nov 9, 2021
|
Checklist is good with exception about qsub falcon test. |
|
@joshua-cogliati-inl I have merged your PR, and thanks for your contribution. |
|
Job Test qsubs sawtooth on bb34c45 : invalidated by @joshua-cogliati-inl checking again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows regression to be done for non-timeseries data.
Pull Request Description
What issue does this change request address?
Closes #1706
What are the significant changes in functionality due to this change request?
Adds a Keras MLP Regression class, and fixes a bug in the Keras Regression.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>to True.raven/tests/framework/user_guideandraven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.