-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensemble Rom #1720
Ensemble Rom #1720
Conversation
…ression plots vs. individual ROMs
…e users to multioutput layer for outer estimator
Job Test qsubs falcon on 09fd2e0 : invalidated by @wangcj05 missing conda environment |
Job Test qsubs falcon on bae6738 : invalidated by @wangcj05 rerun |
@@ -131,7 +131,6 @@ def _initializeLSpp(self, runInfo, inputs, initDict): | |||
self.ROM.initializeModel(settings) | |||
else: | |||
self.ROM = self.assemblerDict['ROM'][0][3] | |||
self.ROM.reset() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes me pretty nervous. What else changed that supports removing this reset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just do not see the value for the reset here, it seems to me it is at the initialization stage, the ROM is initialized during this stage, why do we need to reset it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I don't disagree. I wonder why it was added in the first place.
Job Test qsubs sawtooth on bae6738 : invalidated by @wangcj05 |
1 similar comment
Job Test qsubs sawtooth on bae6738 : invalidated by @wangcj05 |
@mandd Do you have time to review this PR? |
PR is green to me. Merging |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
close #1722
The goal of ensemble ROMs (estimators) is to combine the predictions of several base ROMs (estimators) built with a given learning algorithm in order to improve generalizability / robustness over a single ROM.
Two families of ensemble ROMs are usually distinguished:
In averaging methods, the driving principle is to build several estimators independently and then to average their predictions. On average, the combined estimator is usually better than any of the single base estimator because its variance is reduced.
Examples: Bagging methods, Forests of randomized trees, …
By contrast, in boosting methods, base estimators are built sequentially and one tries to reduce the bias of the combined estimator. The motivation is to combine several weak models to produce a powerful ensemble.
Examples: AdaBoost, Gradient Tree Boosting, …
What are the significant changes in functionality due to this change request?
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.