-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Input Templates to inherit from Message User #1757
Conversation
@@ -1804,13 +1804,6 @@ def getInputSpecification(cls): | |||
is returned to $N$). In case the ``with replacement'' strategy is used, the distribution samples | |||
always from the complete set of specified $N$ values. | |||
""" | |||
lb = InputData.parameterInputFactory('lowerBound', contentType=InputTypes.FloatType, printPriority=109, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshua-cogliati-inl I think instead of removing these lines of code, I could use that removeSubWithName()
method you mentioned in chat. Let me know your thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious about why we can remove the upper and lower bounds for these distributions; is it because it's defined in the base class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PaulTalbot-INL Yes, I believe that's why we're getting those INPUT SPEC ERROR
when running HERON before. When I removed the upper and lower bound for these distributions the errors went away.
Job Test qsubs sawtooth on 96f7df4 : invalidated by @PaulTalbot-INL unexpected error: (raylet) ModuleNotFoundError: No module named ''aiohttp.signals'' |
Checklists pass. Merging. |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
#1755
What are the significant changes in functionality due to this change request?
Add explicit warnings to Decorators.py
Add explicit warning for Prescient import error
Remove
lowerBound
andupperBound
as subs from DiscreteUniform and LogNormalLet InputTemplates inherit from MessageUser
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.