Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Input Templates to inherit from Message User #1757

Merged
merged 3 commits into from
Jan 31, 2022

Conversation

dylanjm
Copy link
Collaborator

@dylanjm dylanjm commented Jan 27, 2022


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

#1755

What are the significant changes in functionality due to this change request?

Add explicit warnings to Decorators.py
Add explicit warning for Prescient import error

Remove lowerBound and upperBound as subs from DiscreteUniform and LogNormal

Let InputTemplates inherit from MessageUser


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@@ -1804,13 +1804,6 @@ def getInputSpecification(cls):
is returned to $N$). In case the ``with replacement'' strategy is used, the distribution samples
always from the complete set of specified $N$ values.
"""
lb = InputData.parameterInputFactory('lowerBound', contentType=InputTypes.FloatType, printPriority=109,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshua-cogliati-inl I think instead of removing these lines of code, I could use that removeSubWithName() method you mentioned in chat. Let me know your thoughts.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about why we can remove the upper and lower bounds for these distributions; is it because it's defined in the base class?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PaulTalbot-INL Yes, I believe that's why we're getting those INPUT SPEC ERROR when running HERON before. When I removed the upper and lower bound for these distributions the errors went away.

@dylanjm dylanjm mentioned this pull request Jan 27, 2022
9 tasks
@moosebuild
Copy link

Job Test qsubs sawtooth on 96f7df4 : invalidated by @PaulTalbot-INL

unexpected error: (raylet) ModuleNotFoundError: No module named ''aiohttp.signals''

@PaulTalbot-INL PaulTalbot-INL linked an issue Jan 31, 2022 that may be closed by this pull request
10 tasks
@PaulTalbot-INL PaulTalbot-INL merged commit edbbe94 into idaholab:devel Jan 31, 2022
@PaulTalbot-INL
Copy link
Collaborator

Checklists pass. Merging.

@dylanjm dylanjm deleted the add-warnings branch January 30, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Allow InputTemplates to inherit from Message User
3 participants