-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ability for plugins to find the crow module #1803
Conversation
Job Mingw Test on e6c63fc : invalidated by @dylanjm Looks like it got hung up fetching RAVEN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is tricker code than it looks, so some fixes are needed.
##TODO REMOVE PP3 WHEN RAY IS AVAILABLE FOR WINDOWS | ||
utils.add_path_recursively(os.path.join(frameworkDir,'contrib','pp')) | ||
ravenDir = os.path.dirname(frameworkDir) | ||
if any(os.path.normcase(sp) == os.path.join(ravenDir, 'crow') for sp in sys.path): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crow actually is just the c++ build files and so will not be in the path. Also, find_crow does check to see if crow can be imported before adding to the path.
@joshua-cogliati-inl All checks passed. Ready for another once over. This PR is needed to merge HERON Framework PR and to also run the parallel case on HPC. |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
#1764
What are the significant changes in functionality due to this change request?
This just ensures that the crow module path is correctly specified before trying to find the crow module in
utils.randomUtils.py
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.