-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAVEN running RAVEN in Python or Jupyter Notebook Workflows #1816
RAVEN running RAVEN in Python or Jupyter Notebook Workflows #1816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good; a couple minor comments for consideration.
@@ -0,0 +1,73 @@ | |||
<Simulation verbosity="debug"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file different than the one we keep in the RrR integrated tests? If not, could we load that workflow from here, or does that create some kind of pathing nightmare? It would be convenient not to maintain the same "outer" and "inner" files in both places, but idk if we can pull that off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the same file. It looks like I can just update the path to point to the preexisting file and it will run just fine.
return 1.0 | ||
|
||
def run(self,Input): | ||
self.ans = evaluate(Input.values()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This model is in raven/tests/framework/AnalyticTests
, I think, so we shouldn't have to duplicate it here, but rather provide a path to that one in the "inner".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit more involved (the inner file I point to has a copy of attenuate.py in the directory). Changing the path will work here and reduce the number of files in the original RrR test and the new Python RrR test.
Job Test qsubs sawtooth on d4c5c41 : invalidated by @dgarrett622 failed qsubs, try again |
Job Test qsubs sawtooth on d4c5c41 : invalidated by @dgarrett622 timeout on test_parallel_hybride_model_external |
Job Test qsubs sawtooth on d4c5c41 : invalidated by @dgarrett622 try again |
Job Test qsubs sawtooth on d4c5c41 : invalidated by @dgarrett622 run sawtooth tests again |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Continues #1682
What are the significant changes in functionality due to this change request?
Builds off of #1685 to allow running RrR workflows in python scripts or Jupyter Notebooks.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.