Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAVEN running RAVEN in Python or Jupyter Notebook Workflows #1816

Merged
merged 6 commits into from
Apr 25, 2022

Conversation

dgarrett622
Copy link
Collaborator

@dgarrett622 dgarrett622 commented Apr 20, 2022


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Continues #1682

What are the significant changes in functionality due to this change request?

Builds off of #1685 to allow running RrR workflows in python scripts or Jupyter Notebooks.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@dgarrett622 dgarrett622 self-assigned this Apr 20, 2022
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good; a couple minor comments for consideration.

@@ -0,0 +1,73 @@
<Simulation verbosity="debug">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file different than the one we keep in the RrR integrated tests? If not, could we load that workflow from here, or does that create some kind of pathing nightmare? It would be convenient not to maintain the same "outer" and "inner" files in both places, but idk if we can pull that off.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the same file. It looks like I can just update the path to point to the preexisting file and it will run just fine.

return 1.0

def run(self,Input):
self.ans = evaluate(Input.values())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This model is in raven/tests/framework/AnalyticTests, I think, so we shouldn't have to duplicate it here, but rather provide a path to that one in the "inner".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit more involved (the inner file I point to has a copy of attenuate.py in the directory). Changing the path will work here and reduce the number of files in the original RrR test and the new Python RrR test.

@moosebuild
Copy link

Job Test qsubs sawtooth on d4c5c41 : invalidated by @dgarrett622

failed qsubs, try again

@moosebuild
Copy link

Job Test qsubs sawtooth on d4c5c41 : invalidated by @dgarrett622

timeout on test_parallel_hybride_model_external

@moosebuild
Copy link

Job Test qsubs sawtooth on d4c5c41 : invalidated by @dgarrett622

try again

@moosebuild
Copy link

Job Test qsubs sawtooth on d4c5c41 : invalidated by @dgarrett622

run sawtooth tests again

@PaulTalbot-INL PaulTalbot-INL merged commit 835b198 into idaholab:devel Apr 25, 2022
@dgarrett622 dgarrett622 deleted the triple_pirate_says branch April 25, 2022 22:57
@wangcj05 wangcj05 added the RAVENv2.2 for RAVENv2.2 Release label Jun 16, 2022
@dgarrett622 dgarrett622 mentioned this pull request Jul 11, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RAVENv2.2 for RAVENv2.2 Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants