Added the capability to specify time interval and removed function to… #1830

yoshiurr-INL · 2022-05-13T20:01:24Z

… postprocess more than one feature and target set per step

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

What are the significant changes in functionality due to this change request?

Allows users to specify time intervals in ratio terms of the full time interval (pivot parameter). To prevent confusion, the capability to postprocess multiple pairs of features and targets in one single step has been deprecated. To postprocess multiple time intervals, the user will now have to create a new step and add it to the sequence.

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

1. Review all computer code.
2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
8. If an analytic test is changed/added is the the analytic documentation updated/added?
9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

… postprocess more than one feature and target set per step

Uploading required test files that were not addable during local branch merging.

moosebuild · 2022-05-13T20:45:15Z

Job Mingw Test on 95a2587 : invalidated by @yoshiurr-INL

Random issue

wangcj05

I would like to keep the capacities to compute multiple feature-target pairs in the single post-processors. @yoshiurr-INL Please let me know what do you think.

yoshiurr-INL · 2022-05-16T22:20:38Z

I considered reenabling the multiple feature-target pairs but realized this would essentially require the user to create multiple DataObjects and OutStreams anyway due to potentially using different pivot parameters depending on how many data points is provided from the feature and target.

If we recall, 'pivotParameterFeature' and 'pivotParameterTarget' are utilized for this postprocessor. If the grids are nonuniform, it is possible for one transient to use 'pivotParameterFeature' and for another transient to use 'pivotParameterTarget' due to the auto-selection algorithm implemented to choose coarser grids and have the finer data interpolate/extrapolate.

Then, the pivot parameter for the output DataObject cannot be described using a single pivot parameter. To avoid this risk, I propose to keep the current changes.

For the suggestion to add an attribute to provide the user the choice to use ratio or raw time values, I agree that should be an option and will make changes ASAP.

yoshiurr-INL · 2022-05-17T21:05:18Z

The capability to use ratios and raw values is now available.

moosebuild · 2022-05-18T14:13:09Z

Job Test qsubs sawtooth on 7c94021 : invalidated by @yoshiurr-INL

Restart Sawtooth tests

wangcj05

@yoshiurr-INL I have some comments for your consideration.

doc/user_manual/PostProcessors/Validation.tex

ravenframework/Models/PostProcessors/Validations/PPDSS.py

tests/framework/PostProcessors/Validation/test_validation_dss.xml

moosebuild · 2022-05-26T13:32:03Z

Job Test qsubs sawtooth on d444b2f : invalidated by @yoshiurr-INL

Restart Sawtooth tests

moosebuild · 2022-05-26T13:57:13Z

Job Test qsubs sawtooth on d444b2f : invalidated by @yoshiurr-INL

Restart Sawtooth tests

moosebuild · 2022-05-27T19:28:29Z

Job Test qsubs sawtooth on d444b2f : invalidated by @yoshiurr-INL

Restart Sawtooth tests

wangcj05

I have some minor comments for you to consider.

wangcj05 · 2022-06-02T21:18:21Z

doc/user_manual/PostProcessors/Validation.tex

+    it will output an error.
+  \item \xmlNode{Targets}, \xmlDesc{comma separated string, required field}, specifies the names of the targets. Make sure the feature data are normalized by a nominal value. \nb Each target is paired with a feature listed in xml node \xmlNode{Features}.
+    To enable user defined time interval selection, this postprocessor will only consider the first feature name provided. If user provides more than one,
+    itt will output an error.


wangcj05 · 2022-06-02T21:22:30Z

doc/user_manual/PostProcessors/Validation.tex

+  \item \xmlNode{Options}
+  \begin{itemize}
+    \item \xmlNode{pivotParameter}
+  \end{itemize}


Do you need these lines?

Do not need these. Deleted.

wangcj05 · 2022-06-02T21:27:15Z

ravenframework/Models/PostProcessors/Validations/PPDSS.py

+    separateFeatureDataInput.addParam("type", InputTypes.StringType, descr="""Specifies what type of user defined time intervals have been selected from
+                                                                    the feature pivot parameter. Options are currently `ratio' or `raw_values'""")


Let's use raw string descr = r""" .... """, and change "raw_values" --> raw\_values

wangcj05 · 2022-06-02T21:27:34Z

ravenframework/Models/PostProcessors/Validations/PPDSS.py

+    separateTargetDataInput.addParam("type", InputTypes.StringType, descr="""Specifies what type of user defined time intervals have been selected from
+                                                                    the target pivot parameter. Options are currently `ratio' or `raw_values'""")


similar to above comment

moosebuild · 2022-06-12T15:22:39Z

Job Test qsubs sawtooth on 08e843a : invalidated by @yoshiurr-INL

Restart Sawtooth tests

moosebuild · 2022-06-13T20:33:13Z

Job Test qsubs sawtooth on 08e843a : invalidated by @wangcj05

wangcj05 · 2022-06-15T17:32:22Z

PR checklist is satisfied.

Added the capability to specify time interval and removed function to…

b2d5142

… postprocess more than one feature and target set per step

yoshiurr-INL added the Ready To Review label May 13, 2022

yoshiurr-INL requested a review from wangcj05 May 13, 2022 20:01

yoshiurr-INL self-assigned this May 13, 2022

Add files via upload

95a2587

Uploading required test files that were not addable during local branch merging.

wangcj05 reviewed May 16, 2022

View reviewed changes

Added capability to specify in ratios and raw values.

18b0467

Fixed doc issues in user manual

7c94021

Added content to specify pivot paramter format for output DataObjects

c70a712

wangcj05 requested changes May 18, 2022

View reviewed changes

yoshiurr-INL added 2 commits May 25, 2022 15:59

Changed files based on review comments.

d65bf9d

Forgot to add backslash to underscore text.

d444b2f

yoshiurr-INL requested a review from wangcj05 May 31, 2022 18:41

wangcj05 requested changes Jun 2, 2022

View reviewed changes

Made user manual edits and docstring edits according to review.

08e843a

wangcj05 approved these changes Jun 13, 2022

View reviewed changes

wangcj05 merged commit 2ef0a74 into devel Jun 15, 2022

wangcj05 deleted the yoshrk-dss-individual-phase-analysis branch June 15, 2022 17:32

wangcj05 added the RAVENv2.2 for RAVENv2.2 Release label Jun 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added the capability to specify time interval and removed function to… #1830

Added the capability to specify time interval and removed function to… #1830

yoshiurr-INL commented May 13, 2022 •

edited by wangcj05

Loading

moosebuild commented May 13, 2022

wangcj05 left a comment

yoshiurr-INL commented May 16, 2022

yoshiurr-INL commented May 17, 2022

moosebuild commented May 18, 2022

wangcj05 left a comment

moosebuild commented May 26, 2022

moosebuild commented May 26, 2022

moosebuild commented May 27, 2022

wangcj05 left a comment

wangcj05 Jun 2, 2022

yoshiurr-INL Jun 10, 2022

wangcj05 Jun 2, 2022

yoshiurr-INL Jun 10, 2022

wangcj05 Jun 2, 2022

yoshiurr-INL Jun 10, 2022

wangcj05 Jun 2, 2022

yoshiurr-INL Jun 10, 2022

moosebuild commented Jun 12, 2022

moosebuild commented Jun 13, 2022

wangcj05 commented Jun 15, 2022

		separateFeatureDataInput.addParam("type", InputTypes.StringType, descr="""Specifies what type of user defined time intervals have been selected from
		the feature pivot parameter. Options are currently `ratio' or `raw_values'""")

		separateTargetDataInput.addParam("type", InputTypes.StringType, descr="""Specifies what type of user defined time intervals have been selected from
		the target pivot parameter. Options are currently `ratio' or `raw_values'""")

Added the capability to specify time interval and removed function to… #1830

Added the capability to specify time interval and removed function to… #1830

Conversation

yoshiurr-INL commented May 13, 2022 • edited by wangcj05 Loading

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

What are the significant changes in functionality due to this change request?

For Change Control Board: Change Request Review

moosebuild commented May 13, 2022

wangcj05 left a comment

Choose a reason for hiding this comment

yoshiurr-INL commented May 16, 2022

yoshiurr-INL commented May 17, 2022

moosebuild commented May 18, 2022

wangcj05 left a comment

Choose a reason for hiding this comment

moosebuild commented May 26, 2022

moosebuild commented May 26, 2022

moosebuild commented May 27, 2022

wangcj05 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moosebuild commented Jun 12, 2022

moosebuild commented Jun 13, 2022

wangcj05 commented Jun 15, 2022

yoshiurr-INL commented May 13, 2022 •

edited by wangcj05

Loading