Eliminate inefficient Python for loops #1877
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Maintainers of this repo,
Thank you very much for your excellent work,
I am new to this repository.
I am a researcher studying the best practices of evolving data science codes. According to our findings, migration of loop-based computations is a common evolution practice among the developers since it increases performance and code quality. I observed the code in this PR where it could make better use of functions from NumPy and functions from Python.
This PR is a minor contribution compared to all the hard work that you have done in this repo. However, I am hoping that it will enhance code quality and, hopefully, performance.
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
This is not a reported issue
#1806
What are the significant changes in functionality due to this change request?
This is a code refactoring
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.