Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate inefficient Python for loops #1877

Merged
merged 4 commits into from
Jul 6, 2022
Merged

Conversation

maldil
Copy link
Contributor

@maldil maldil commented Jul 1, 2022

Hi Maintainers of this repo,

Thank you very much for your excellent work,

I am new to this repository.
I am a researcher studying the best practices of evolving data science codes. According to our findings, migration of loop-based computations is a common evolution practice among the developers since it increases performance and code quality. I observed the code in this PR where it could make better use of functions from NumPy and functions from Python.

This PR is a minor contribution compared to all the hard work that you have done in this repo. However, I am hoping that it will enhance code quality and, hopefully, performance.


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

This is not a reported issue
#1806

What are the significant changes in functionality due to this change request?

This is a code refactoring


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

Copy link
Collaborator

@wangcj05 wangcj05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maldil Thanks for your contribution. I have just one comment for you to consideration. Could you make the change so that I can merge your contribution into RAVEN devel.

ravenframework/SupervisedLearning/MSR.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@wangcj05 wangcj05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

@wangcj05
Copy link
Collaborator

wangcj05 commented Jul 6, 2022

checklist passed, PR can be merged.

@wangcj05 wangcj05 merged commit 0d02368 into idaholab:devel Jul 6, 2022
@wangcj05
Copy link
Collaborator

wangcj05 commented Jul 6, 2022

@maldil Thanks for your contribution, I have merged your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants