-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging scripts #1967
Packaging scripts #1967
Conversation
eac6b66
to
eedaa41
Compare
Job Mingw Test on 59deaba : invalidated by @joshua-cogliati-inl failed in fetch |
1 similar comment
Job Mingw Test on 59deaba : invalidated by @joshua-cogliati-inl failed in fetch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are good. By the way, could you add some instruction on how to use these scripts. @joshua-cogliati-inl
PR looks good, once tests passed, the PR can be merged. |
Checklist is good, and tests are good. |
Pull Request Description
What issue does this change request address?
#1764
What are the significant changes in functionality due to this change request?
Adds a script to build python 3.7 and 3.8 packages,
Adds a script to test that the pip packages are installable.
Improves the setup.py file by improving description and adding readme as long description.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.