Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying for tensorflow 2.9 #1973

Merged
merged 6 commits into from
Oct 5, 2022
Merged

Conversation

joshua-cogliati-inl
Copy link
Contributor

@joshua-cogliati-inl joshua-cogliati-inl commented Sep 20, 2022


Pull Request Description

What issue does this change request address?

#1972

What are the significant changes in functionality due to this change request?

Updates to tensorflow 2.9


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@moosebuild
Copy link

Job Mingw Test on 9caf220 : invalidated by @joshua-cogliati-inl

failed in fetch

@joshua-cogliati-inl
Copy link
Contributor Author

Changed tests:
From Tensorflow and related updates:

  • tests/framework/MCMC/MetropolisTenDimPropMVN
  • tests/framework/PostProcessors/TSACharacterizer/Basic
  • tests/framework/CodeInterfaceTests/DymolaTestTimeDepNoExecutableEnsembleModel
  • tests/framework/ROM/TimeSeries/ARMA/MulticycleReseed
  • tests/framework/ROM/TimeSeries/SyntheticHistory/Interpolated
  • tests/framework/ROM/tensorflow_keras/tf_cnn1d
  • tests/framework/ROM/tensorflow_keras/tf_lstm
  • tests/framework/ROM/tensorflow_keras/LSTMFromFile

From Scikitlearn update:

  • tests/framework/PostProcessors/DataMiningPostProcessor/DimensionalityReduction/SpectralEmbedding
  • tests/framework/PostProcessors/LimitSurface/testLimitSurfaceIntegralPPWithBoundingError
  • tests/framework/PostProcessors/TemporalDataMiningPostProcessor/Clustering/MiniBatchKMeans

@moosebuild
Copy link

Job Test mac on dd3d3ec : invalidated by @joshua-cogliati-inl

failed Diff tests/framework/PostProcessors/EconomicRatio/timeDepDataset

Copy link
Collaborator

@dylanjm dylanjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me and changed tests have been explained in a comment above.

dylanjm
dylanjm previously approved these changes Sep 30, 2022
@joshua-cogliati-inl
Copy link
Contributor Author

@wangcj05 Any objections to merging this? As a warning it breaks HERON and LOGOS. HERON is probably just an update of a pickle file (tho' @dylanjm or I should probably double check that).

Copy link
Collaborator

@wangcj05 wangcj05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one comment. I think in the future we need to have more consistent tests for tensorflow.

dependencies.xml Outdated
Comment on lines 48 to 49
<tensorflow os='windows,linux'>2.9</tensorflow>
<tensorflow os='mac'>2.9</tensorflow>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these be combined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, yes.

@moosebuild
Copy link

Job Mingw Test on 84d278e : invalidated by @joshua-cogliati-inl

FAILED: Diff tests/framework/PostProcessors/EconomicRatio/timeDepDataset

Copy link
Collaborator

@wangcj05 wangcj05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good.

@wangcj05
Copy link
Collaborator

wangcj05 commented Oct 5, 2022

checklist is good, tests are green. PR can be merged.

@wangcj05 wangcj05 merged commit b07ea40 into idaholab:devel Oct 5, 2022
@wangcj05
Copy link
Collaborator

wangcj05 commented Oct 5, 2022

@joshua-cogliati-inl I have merged your PR, thanks for your contribution. Here are additional requests:

  • Please send an email to user group since this PR updates several libraries

  • Please send an email to plugin developer, since several of them failed due to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants