-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying for tensorflow 2.9 #1973
Conversation
17b369a
to
3a23f91
Compare
Job Mingw Test on 9caf220 : invalidated by @joshua-cogliati-inl failed in fetch |
9caf220
to
3583ce7
Compare
Changed tests:
From Scikitlearn update:
|
Job Test mac on dd3d3ec : invalidated by @joshua-cogliati-inl failed Diff tests/framework/PostProcessors/EconomicRatio/timeDepDataset |
dd3d3ec
to
9e6934c
Compare
9e6934c
to
99fd297
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me and changed tests have been explained in a comment above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one comment. I think in the future we need to have more consistent tests for tensorflow.
dependencies.xml
Outdated
<tensorflow os='windows,linux'>2.9</tensorflow> | ||
<tensorflow os='mac'>2.9</tensorflow> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these be combined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, yes.
Job Mingw Test on 84d278e : invalidated by @joshua-cogliati-inl FAILED: Diff tests/framework/PostProcessors/EconomicRatio/timeDepDataset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good.
checklist is good, tests are green. PR can be merged. |
@joshua-cogliati-inl I have merged your PR, thanks for your contribution. Here are additional requests:
|
Pull Request Description
What issue does this change request address?
#1972
What are the significant changes in functionality due to this change request?
Updates to tensorflow 2.9
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.