Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Inputs for dummy models #2006

Merged
merged 4 commits into from
Nov 18, 2022
Merged

Multiple Inputs for dummy models #2006

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a75a8e
edit dummy models
mandd Nov 9, 2022
5f9875b
added input check only for ROM
mandd Nov 17, 2022
8c1b957
addressing comments
mandd Nov 17, 2022
1ee015e
edit ROM class
mandd Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ravenframework/Models/Dummy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,6 @@ def _manipulateInput(self,dataIn):
@ In, dataIn, object, the object that needs to be manipulated
@ Out, inRun, dict, the manipulated input
"""
if len(dataIn)>1:
self.raiseAnError(IOError,'Only one input is accepted by the model type '+self.type+' with name '+self.name)
if type(dataIn[0])!=tuple:
inRun = self._inputToInternal(dataIn[0]) #this might happen when a single run is used and the input it does not come from self.createNewInput
else:
Expand Down Expand Up @@ -152,9 +150,6 @@ def createNewInput(self,myInput,samplerType,**kwargs):
a mandatory key is the sampledVars'that contains a dictionary {'name variable':value}
@ Out, ([(inputDict)],copy.deepcopy(kwargs)), tuple, return the new input in a tuple form
"""
if len(myInput)>1:
self.raiseAnError(IOError,'Only one input is accepted by the model type '+self.type+' with name'+self.name)

Comment on lines -155 to -157
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mandd I guess we can remove this constraint for external model, but I think we still need it for ROM. Could you just remove this constraint in the external model.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

inputDict = self._inputToInternal(myInput[0])
self._replaceVariablesNamesWithAliasSystem(inputDict,'input',False)

Expand Down