Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trivial whitespace change. #2113

Open
wants to merge 20 commits into
base: devel
Choose a base branch
from
Open

Trivial whitespace change. #2113

wants to merge 20 commits into from

Conversation

joshua-cogliati-inl
Copy link
Contributor

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
What are the significant changes in functionality due to this change request?

This is a trivial change to check the build system.

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@moosebuild
Copy link

Job Mingw Test on 8d0aadf : invalidated by @joshua-cogliati-inl

restarted civet

@moosebuild
Copy link

Job Mingw Test on 8d0aadf : invalidated by @joshua-cogliati-inl

failed in fetch

@moosebuild
Copy link

Job Mingw Test on 8d0aadf : canceled by @joshua-cogliati-inl

Was just to test fetch, which succeeded.

@moosebuild
Copy link

Job Test mac on 8d0aadf : canceled by @joshua-cogliati-inl

this was a test to make sure the regression testing system was working.

@wangcj05
Copy link
Collaborator

@joshua-cogliati-inl Do you want to keep this PR for testing or you can close it?

@joshua-cogliati-inl
Copy link
Contributor Author

@joshua-cogliati-inl Do you want to keep this PR for testing or you can close it?

It is handy to have around, and this is at least the 3rd trivial PR that has been opened, so if it is closed, a new one will probably be opened again at some point.

@moosebuild
Copy link

Job Test mac on d849ad0 : canceled by @joshua-cogliati-inl

Was just to check civet.

@moosebuild
Copy link

Job Mingw Test on 584b5fd : canceled by @joshua-cogliati-inl

Was just to check cpu usage.

@moosebuild
Copy link

Job Test qsubs sawtooth on 723694e : invalidated by @joshua-cogliati-inl

ran conda clean

@moosebuild
Copy link

Job Test CentOS 8 on 52f5b6d : invalidated by @joshua-cogliati-inl

killed long running ipopt

@moosebuild
Copy link

Job Mingw Test on 52f5b6d : canceled by @joshua-cogliati-inl

Was just to check a problem happening on linux machines.

@moosebuild
Copy link

Job Test Ubuntu 18 PIP on baf6f9f : invalidated by @joshua-cogliati-inl

failed in set python environment with old_record_path = cast("RecordPath", row[0]) IndexError: list index out of range

@moosebuild
Copy link

Job Test Ubuntu 18 PIP on baf6f9f : invalidated by @joshua-cogliati-inl

failed in fetch

@wanghy-anl wanghy-anl mentioned this pull request Oct 10, 2023
Merged
9 tasks
@moosebuild
Copy link

Job Test Ubuntu 18 PIP on baf6f9f : invalidated by @joshua-cogliati-inl

Failed File "/home/civet/pip_envs/raven_libraries/lib/python3.8/site-packages/pip/_internal/operations/install/wheel.py", line 258, in get_csv_rows_for_installed old_record_path = cast("RecordPath", row[0]) IndexError: list index out of range

@moosebuild
Copy link

Job Test qsubs sawtooth on 3b85cef : canceled by @joshua-cogliati-inl

Was just to check a problem happening on linux machines.

@moosebuild
Copy link

Job Mingw Test on 3b85cef : canceled by @joshua-cogliati-inl

Was just to check a problem happening on linux machines.

@joshua-cogliati-inl
Fixes problems finding raven libraries with conda
b409291 
If for example, the library name is raven_libraries but a raven_libraries_2_0
existed, the previous test would match, and then the conda remove could fail.
@moosebuild
Copy link

Job Test qsubs sawtooth on b409291 : invalidated by @joshua-cogliati-inl

passed in set python environment

@moosebuild
Copy link

Job Test mac on b409291 : invalidated by @joshua-cogliati-inl

failed with python3.12/site-packages/mamba/mamba.py", line 558, in install transaction.fetch_extract_packages()

@moosebuild
Copy link

Job Precheck on 6085ce4 : invalidated by @joshua-cogliati-inl

failed precheck

@moosebuild
Copy link

Job Test qsubs sawtooth on 6105e93 : invalidated by @joshua-cogliati-inl

failed in set python environment (solving environment took over 5 hours)

@moosebuild
Copy link

Job Test Fedora 31 on 6105e93 : invalidated by @joshua-cogliati-inl

testing civet after upgrade

@moosebuild
Copy link

Job Test qsubs sawtooth on 2a974b0 : invalidated by @joshua-cogliati-inl

testing civet after upgrade

@moosebuild
Copy link

Job Precheck on 6085ce4 : invalidated by @joshua-cogliati-inl

testing civet after upgrade

@moosebuild
Copy link

Job Mingw Test on 6105e93 : invalidated by @joshua-cogliati-inl

testing civet after upgrade

@moosebuild
Copy link

Job Precheck on 6085ce4 : invalidated by @joshua-cogliati-inl

hpcgitlab back up

@moosebuild
Copy link

Job Test qsubs sawtooth on 6085ce4 : invalidated by @joshua-cogliati-inl

failed in fetch

@moosebuild
Copy link

Job Test CentOS 8 on 6085ce4 : invalidated by @joshua-cogliati-inl

restarted civet

@moosebuild
Copy link

Job Test Fedora 32 on 6085ce4 : invalidated by @joshua-cogliati-inl

restarted civet

@joshua-cogliati-inl joshua-cogliati-inl mentioned this pull request May 14, 2024
Merged
9 tasks
@moosebuild
Copy link

Job Mingw Test on 16b5297 : invalidated by @joshua-cogliati-inl

multiple failed tests with timeout.

@moosebuild
Copy link

Job Mingw Test on 16b5297 : invalidated by @joshua-cogliati-inl

restarted civet

@moosebuild
Copy link

Job Test CentOS 8 on 16b5297 : invalidated by @joshua-cogliati-inl

restarted civet

@moosebuild
Copy link

Job Test CentOS 8 on 16b5297 : invalidated by @joshua-cogliati-inl

hpcgitlab back up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Do Not Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshua-cogliati-inl @moosebuild @wangcj05 @alfoa