-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Bayesian Optimization #2123
Conversation
20e8966
to
0c0f0ef
Compare
0c0f0ef
to
20561aa
Compare
20561aa
to
8ffb6be
Compare
8ffb6be
to
3d06742
Compare
3d06742
to
15eb19c
Compare
15eb19c
to
3920688
Compare
Test failed on some linux machine: @AnthoneyGriffith Could you take a look? |
@joshua-cogliati-inl @PaulTalbot-INL @dylanjm This PR is ready for review. Are you available to review this PR? |
Job Test Ubuntu 16 on 26fbeb0 : canceled by @joshua-cogliati-inl stuck running HERON tests |
Job Test Fedora 31 on 26fbeb0 : canceled by @joshua-cogliati-inl stuck running HERON tests |
Job Test CentOS 8 on 26fbeb0 : canceled by @joshua-cogliati-inl stuck running HERON tests |
Job Test CentOS 7 on 26fbeb0 : canceled by @joshua-cogliati-inl stuck running HERON tests |
Job Test Fedora 32 on 26fbeb0 : canceled by @joshua-cogliati-inl stuck running HERON tests |
Job Test Ubuntu 20-2 Optional on 26fbeb0 : canceled by @joshua-cogliati-inl stuck running HERON tests |
Job Test Ubuntu 18-2 Python 3 on 26fbeb0 : canceled by @joshua-cogliati-inl stuck running HERON tests |
Job Test qsubs sawtooth on 26fbeb0 : canceled by @joshua-cogliati-inl stuck running HERON tests |
The following tests fail the XSD check ( ./developer_tools/validate_xml.sh ):
developer_tools/XSDSchemas/Optimizers.xsd will probably need to be modified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed most of it, will review again after some changes are made. I'm open to discussion on any suggested change.
ravenframework/Optimizers/acquisitionFunctions/ExpectedImprovement.py
Outdated
Show resolved
Hide resolved
Job Test qsubs sawtooth on 52dec74 : invalidated by @joshua-cogliati-inl failed in fetch |
Job Test CentOS 7 on cca7e06 : invalidated by @joshua-cogliati-inl raven updated. |
…olveNewOptPoint, to account for noisy observations
…recommend solution method to account for this change
56e7450
to
0f880d3
Compare
Job Test Ubuntu 18-2 Python 3 on 8f948d8 : invalidated by @joshua-cogliati-inl killed long running ipopt |
Job Test qsubs sawtooth on 8f948d8 : invalidated by @joshua-cogliati-inl Caused by HPC problem: [HPC #18342] |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #2124
What are the significant changes in functionality due to this change request?
This change request adds a new optimizers node 'BayesianOptimizer', which allows for the specification of a Bayesian
Optimization algorithm. This method also requires the specification of a GPR ROM under the Models node. The GPR ROM node is also extended to include custom kernel specification and anisotropic kernels. These changes are intended to improve the use of the Bayesian Optimizer.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.