-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RavenFramework tests using pip package or pre-built executable #2273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like where this patch is going and it will be useful. I think there are parts that can be simplified (if I am wrong feel free to explain what I missed). Thanks.
if executable == 'raven_framework': | ||
# (j-bryan, 2024-03-05) A raven_framework script may also be the command used to run RAVEN, such | ||
# as when using a prebuilt executable of RAVEN. | ||
if executable == '%RAVENFRAMEWORK%': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Various comments:
- RAVENEXECUTABLE might be more self explanatory than RAVENFRAMEWORK
- Why can't this all be in ravenframework//Models/Code.py with the other command mangling?
Job Test Ubuntu 18-2 Python 3 on 1a34487 : invalidated by @joshua-cogliati-inl removed numexpr so retrying test |
The recent commit (8c67f36) is a large rework of the capability with an emphasis on simplicity. The major changes are
|
Job Test mac on 6828a8e : invalidated by @joshua-cogliati-inl failed in set python environment |
Job Test qsubs sawtooth on 6206fd8 : invalidated by @j-bryan Rerunning to get log files on failing qsubs test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and approve.
@@ -50,7 +50,7 @@ | |||
<!-- MODELS --> | |||
<Models> | |||
<Code name="raven_running_rom" subType="RAVEN"> | |||
<executable>%FRAMEWORK_DIR%/../raven_framework</executable> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, should this be left as is?
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
#2272
What are the significant changes in functionality due to this change request?
Adds the ability to run RavenFramework tests using either a pip-installed version of raven or a prebuilt executable of raven. Note that as currently implemented, the other types of raven tests (e.g. RavenPython) and the plugin tests will run using the development version of raven and its installed plugins, not the alternative installation.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.