Add "long" data type compatability #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into dataobject-rework
…into dataobject-rework
…into dataobject-rework
|
@PaulTalbot-INL is this a problem that affects the dataobject-rework branch only or it affects devel as well? |
|
ok I saw that in the issue you specified it affects dataobject-rework only |
|
From what I can tell, we always cast entries as "floats" in the old scheme; it wasn't until the rework that we started allowing more types. |
|
@PaulTalbot-INL I took a look at the test failing in Linux. there are several diffs and some crashes. |
|
I can get a wide variety of responses depending on the numpy, xarray, and pandas library version. I'm looking into the best way to work with this. |
|
Job Test linux on 4be3a13 : invalidated by @PaulTalbot-INL Claims "cython" is not found, which should not be possible. Retrying. |
|
This needs to rerun tests after #595 is merged. |
|
@PaulTalbot-INL. As you asked me, I verified the following on my RAVEN windows installation:
|
|
Perfect! Thanks for your help, and sorry for the headaches it may have caused prematurely. |
|
Job Mingw Test on 4964e6c : invalidated by @alfoa |
|
Job Test linux on 4964e6c : invalidated by @alfoa |
|
@PaulTalbot-INL The tests on Linux and Windows are failing. Do you have an idea why? |
|
The Windows tests are failing because it can't check out CashFlow due to the HPC outage, for the record. |
|
did you check locally that Windwos passes? |
|
I'm still having an issue with the grid forward sampling, I'm looking into it. I'll let you know when it clears. |
|
Job Test linux on 892df27 : invalidated by @alfoa |
|
Job Mingw Test on 892df27 : invalidated by @alfoa |
|
Job Test linux on 892df27 : invalidated by @alfoa |
|
@derekstucki The Windows machine (even if the tests completed) does not return and it is shown as "pending" |
|
@derekstucki and in the MAC machine, the following libraries are not found: but the step is tagged as green. Probably the script does not return an error code. We have to fix this. |
|
The MAC machine needs to be fixed. The others show the green light. |
Merged
alfoa
pushed a commit
that referenced
this pull request
Jul 23, 2018
* first draft * convert metric pp to use new data objects (#462) * convert metric pp to use new data objects * clean up * Mods for new dataObject (#463) * edits * edits * comments review-1 * edits * asDictionary works * added full loop cycle test * initial test * pk * diff algorithm * ok * dataobject rework: Optimizer (#461) * adaptive sparse grid, sobol working * Adaptive sampling, plus Dummy-based rlz updates from input, output * cleanup * added cluster labeling to outstream print, will be tested with optimizer * optimizers working, but need to fix reading from CSV before merging * stash * fixed prefix as numpy array * loading CSV correctly now, so optimizer can find optimal solns * cleanup * now handling infs and nans * cleanup * added the option to avoid to reprint the files in case their content did not change * reverted 101 tests modified by the conversion scripts (by mistake) * reverted other tests * reverted tests user guide * reverted all the other tests * Update beale.xml removed ```"``` * removed " * removed abstract method that has been removed from the XDataSet * fixed with respect to the new prefix strategy * fixed loading of dataset in case no metadata are found in the xml (finally statement in a try except is always executed) * fixed type in ROM causing a failure * fixed another typo that was making the Dummy.py model to fail * removed whitespace that was added from another commit * updated to use pd.isnull instead of np.isnan in unordered CSV differ * test files for differ * new input * fix * ok * convert CrossValidation PP to use new data objects. (#470) * fix typo in rom * modify tests * convert cross validation pp * convert tests for cross validation pp * clean up * keep the options to dump the cross validation results for each fold * update conversion scripts for cross validation * Fixing no-meta CSV reading (#473) * fixed history set reading from CSV if no XML present, or if present for that matter * fixed up PointSet and DataSet versions, too. * finished * added tests * ok * ok * Doing better than "object" typing in DataObject (#478) * typing is now working, but if more samples are taken after asDataset is called, and asDataset is called again, integers will be converted into floats. I submitted a stackOverflow question about this, and we will see. * fixed integer preservation using concat instead of merge * added hierarchical methods (#474) * added hierarchical methods * fixed multiline in databases * added sanity assertion * stash * mechanics in place for hierarchical * hierarchal working with collector OR data * a little more testing * D.O. Rework: Topological PP (#472) * stash * stash * stash * topologicals working * cleanup * review comments * convert importance rank pp to use the new data objects (#477) * convert importance rank pp to use the new data objects * fix comments * convert tests (#480) * LimitSurface adaptive sampler (Standard, Batch, MultiGrid), etc (#469) * fixed return code * starting reworking database * ok * ok * ok * ok * ok * moving ahead * speeded up group search and allgroup list * fixed subgroup * almost done * finished h5py_interface * working on IOStep * dfloat * ok finished database * finished not hirearchical HDF5 and fixed static ROMs * fixed time dep ROMs * addressed Paul's comments * fixed plot * fixed other 2 tests * fixed other 3 tests * regolded another test * initial edits * fixed write...but the history set does not work yet * fixed return code * Update README.md (#439) just removed few sentences * unit tests passing again * slicing now works * added abstract methods to object base * starting reworking database * histories working: * switched to comprehension * fname to fName * removing variables works * added addReal check * Correct setting of default pivots for history set (#448) * fixed default pivot param setting to be in order * put 'time' back in since we handle that now * ok * ok * ok * ok * edits * ok * moving ahead * speeded up group search and allgroup list * fixed subgroup * progressive CSV writing with appends instead of rewriting each iteration for multiruns * cleanup * almost done * finished h5py_interface * working on IOStep * dfloat * ok finished database * finished not hirearchical HDF5 and fixed static ROMs * fixed time dep ROMs * check data alignment works (#452) * fixed no-scalar bug, albeit in a non-traditional way. (#455) * addressed Paul's comments * pylint problems addressed (#451) * pylint problems addressed * Update TestXPointSet.py * malformed comment blocks in 2 tests * new unordered CSV differ, tested on test_Lorentz * convert code to use new data objects (#457) * initial convert of code for new data object * fix bugs in dataset and continue convert code for accepting the new data object * additional converting * clean up * Sampler Restarts (#458) * started work * sampler restarts working * Adaptive Samplers (plus Dummy IO fix) (#459) * adaptive sparse grid, sobol working * Adaptive sampling, plus Dummy-based rlz updates from input, output * cleanup * fixed prefix as numpy array * convert basic statistics pp to use the new data object (#460) * convert basicStatistics to use the new data objects * convert tests of basicStatisitics * convert more tests * clean up * move addMetaKeys to localInputAndChecks * resolve comments * fix checkIndexAlignment in DataSet * add unit test for checkIndexAlignment * Closes #464 * added test * convert metric pp to use new data objects (#462) * convert metric pp to use new data objects * clean up * fixed the tests * added the new gold file for the new test * Mods for new dataObject (#463) * edits * edits * comments review-1 * edits * asDictionary works * added full loop cycle test * fixed plot * fixed other 2 tests * fixed other 3 tests * Update TestXDataSet.py * Update Dummy.py * other tests converted * readded deleted file * almost done * ok * fixed tests * Fixed LimitSurface Postprocessors, added conversion script, added documentation * ok * adapted LimitSurfaceSearch sampler and moved directory for more clearity * almost finished safest point * ok * fixed safest point PP * fixed adaptive batch * modified documentation for SafestPoint * removed Outputhold for Optimizer since is not used and not working * fixed metadata fro samples * removed all * modified unit test * addressed Diego's comments * convert tests (#480) * removed commented part in user manual * addrresed Conjiang's * remove .DS_Store * convert external post processor to use new DataObjects (#479) * convert external pp to use the new data objects * regold tests * fix the DataObjects * address comments * starting reworking database * ok * ok * finished h5py_interface * working on IOStep * dfloat * ok finished database * finished not hirearchical HDF5 and fixed static ROMs * addressed Paul's comments * fixed plot * fixed other 2 tests * fixed other 3 tests * regolded another test * unit tests passing again * slicing now works * starting reworking database * histories working: * removing variables works * ok * ok * progressive CSV writing with appends instead of rewriting each iteration for multiruns * cleanup * finished h5py_interface * working on IOStep * dfloat * ok finished database * finished not hirearchical HDF5 and fixed static ROMs * check data alignment works (#452) * fixed no-scalar bug, albeit in a non-traditional way. (#455) * pylint problems addressed (#451) * pylint problems addressed * Update TestXPointSet.py * malformed comment blocks in 2 tests * new unordered CSV differ, tested on test_Lorentz * Adaptive Samplers (plus Dummy IO fix) (#459) * adaptive sparse grid, sobol working * Adaptive sampling, plus Dummy-based rlz updates from input, output * cleanup * fixed prefix as numpy array * convert basic statistics pp to use the new data object (#460) * convert basicStatistics to use the new data objects * convert tests of basicStatisitics * convert more tests * clean up * move addMetaKeys to localInputAndChecks * resolve comments * fix checkIndexAlignment in DataSet * add unit test for checkIndexAlignment * Closes #464 * convert metric pp to use new data objects (#462) * convert metric pp to use new data objects * clean up * fixed the tests * fixed other 2 tests * other tests converted * readded deleted file * almost done * ok * fixed tests * Fixed LimitSurface Postprocessors, added conversion script, added documentation * ok * adapted LimitSurfaceSearch sampler and moved directory for more clearity * almost finished safest point * ok * fixed safest point PP * fixed adaptive batch * modified documentation for SafestPoint * removed Outputhold for Optimizer since is not used and not working * fixed metadata fro samples * addressed Diego's comments * removed commented part in user manual * addrresed Conjiang's * remove .DS_Store * convert external post processor to use new DataObjects (#479) * convert external pp to use the new data objects * regold tests * fix the DataObjects * address comments * addressed Congjiang's comments * Step forward (#482) * merged Diego's commits for InterfacePostProcessor * Fixed OutStreams printing and regolder foulty ROMs results * modified ARMA tests * fixed reading from CSV of HistorySet (correctly considering the pivotParameter) * fixed * TEMPORARY fix of printing of HISTORY SET * fixed ROM, ARMA, DATABASE (loader), Multiple usage of database * fixed multi target rom and rom trainer test * added the possibility to ask for unfolded XArrays in the realization(...) method * ok * modified other two tests * addressed Paul and Congjiang's comments (no interface PP related) * removed comment that does no apply anymore in HistorySet * fixed another test database * addressed comments * addressed comments 2 * edits * fixed test file * fixed tests (#487) * Mandd/fixed test HS2PS (#488) * fixed tests * edits * edits * edits * Reworked cNDarray, no more replicating indexes (#484) * added a synch checking that is too slow * stash * stash before merging in develop branch * stash * moving back to desktop * got types back * all types including histories now preserved * point set now fixed * dummy fix, mergefix * whitespace * review comment cleanup * Alfoa/continuing work (#486) * regolded XML and added relative tollerance * added warning if no output space has been requested in OutStream Print * Update XHistorySet.py * added selective HDF5 * regolded XML and added relative tollerance * added warning if no output space has been requested in OutStream Print * Update XHistorySet.py * added selective HDF5 * typo endif * fixed HDF5 selective * working on the alias system * fixed alias system tests (but can not be really fixed since the printing of the history set is in random order) * fixed alias system and random history set printing * fixed other 2 tests * Fix the probability weight for ND and 1D distributions (#483) * add regold files * fix probability weight of each sampled variable * address comments * Alfoa/continuing work (#492) * regolded XML and added relative tollerance * added warning if no output space has been requested in OutStream Print * Update XHistorySet.py * added selective HDF5 * regolded XML and added relative tollerance * added warning if no output space has been requested in OutStream Print * Update XHistorySet.py * added selective HDF5 * typo endif * fixed HDF5 selective * working on the alias system * fixed alias system tests (but can not be really fixed since the printing of the history set is in random order) * fixed alias system and random history set printing * fixed other 2 tests * fixed a test * fixed database directory creation (#493) * fixed database directory creation * Update h5py_interface_creator.py removed print statemtnt * Update ExternalModel.py * almost finished ensemble * fix pca related tests. (#496) * fix pca_LHS tests * fix probability weight for sobol and sparse grid related samplers, plus fix the corresponding tests * remove unused gold files * fix ND_test_MC_MVN * fix test Metrics.simpleMetric * fix test EnsembledSampler.EnsembleSamplerConstants * fix probability weight for discrete dist * Alfoa/dataobject rework ensemble model (#498) * Modifications of the ensemble model that fix 8 tests over 12 * fixed test_distribution_combination.xml * added seed in test_distribution_combination.xml and regolded * fixed tests (#490) * fixed tests for TypicalHistory * Mandd/e timporter issues (#501) * fixed tests * edits * edits * edits * edits * edits * edits * edits * edits * edits * edit * edit * edit * edit (#502) * Alfoa/go on ensemble model (#504) * fixed test_output and test_merge_2_databases * fixed hybrid * fixed parser error in tests file * Fixing Tests 1 (#494) * data objects metadata, load csv and history fixed * xml validates * restart csv, mc fixed * improved optimizer infinite test * disabled RavenOutput postprocessor * fixed grid with constants test * cleanup * Add variable probability weights in the Custom Sampler (#505) * add variable probability weight for custom sampler, this will fix the BasicStatistics.timeDependent test * convert test BasicStatistics.timeDependent * fix other tests * fix test framework/Distributions.categorical * add comments * fix comparison statistics (#506) * fix IOStep DataObject to Database * fix comparison statistics * update test test_calc_and_transfer.xml and regold * Non-multilevel Optimizers reworked (#507) * optimizers passing with the new DataObjects except multilevel * Alfoa/data object rework (#509) * fixed CustomSampler * fixed test_output for new version of matplotlib * Alfoa/test fix (#525) * added _reassignSampledVarsPbToFullyCorrVars to Sampler base class. * Script now offers a flag to change ignored files (#508) -e can be followed by a comma separated list of directories or files which will be ignored. Old behavior is to only ignore .git. New default is .git and raven. * fixed run_tests * Framework in makefile (#520) * Added hit to all requirements and clean * Now bindings instead of binary * Moves hit.so to usable location * fixed another parsing error in tests file for framework/PostProcessors/TemporalDataMiningPostProcessor/Clustering.GaussianMixture * added new ID of moose with fix on TestHarness * fixed make file for windows * rework: test harness fix (#526) * fixed test harness to remove output files * Asynchronous History Sampling (#511) * fixed adding histories of different lengths through addRealization * fixed restart MC typo * Fix data mining for the new data object (#512) * edit * edits * initial fix for data mining pp * fix plot and pca * fix plot and HS2PS * fix temporal data mining pp * fix time-dep data mining based on dimensionality reduction * fix dataobjectfilter pp and datamining pp * regold tests, because label switches, and change of prints * addition regold * regold pca * fix comments * fix more comments * fix time-dep basic statistics pp and history set sync pp (#515) * fix time-dep basic statistics pp and history set sync pp * add regold files * fixed internal parallel test for PP (#521) * update user manual for several post-processors (#523) * update documents for basic statistics pp * update documents for metric and cross validation pp * update documents for ImportanceRank pp * update documents for external post-processor * update documents for data mining post processor * resolve comments * rework: raven running raven (#522) * Script now offers a flag to change ignored files (#508) -e can be followed by a comma separated list of directories or files which will be ignored. Old behavior is to only ignore .git. New default is .git and raven. * test added * improving analytic test doc * Generalized typechecking (#524) * isAType and unit tests * converted dataobjects to use mathutils typechecking * regold historysetsyn tests (#529) * starting working on DET * Fix clustering with DTW and ETImporter PP (#531) * fix solution export in Temporal data mining * fix ETImporter and regold AffinityPropogation * fix dtw * External Model collection fix (#534) * fixed external model and added a complexity test * fixed external model to catch more variables * Alfoa/incorrect test files (#535) * fixed inccorect tests * fixed custom mode * removed unuseful stuff * added regold file * fixed AdaptiveBatch test files * fixed test_Custom_Sampler_DataObject.xml * fixes (#533) *Fix interface pp for risk measure * Fix xsd and PostProcess in raven tutorial (#536) * fix postprocess test in the user_guide * fix xsd * comment out the postprocess output * fixed gold file for getpot test (#539) * rework: Multilevel optimizers (#537) * fixed external model and added a complexity test * fixed external model to catch more variables * fixed pathing * fixed infinite missing file * optimizer tests working * rework: CSV fixes and improvements (#538) * loading from dict or CSV now extends existing data instead of replacing it * fixed multiple history csv loading * added failure check test * rework: added libs to conda setup (#542) * added xarray, netcdf4 * trying to fix moosebuild failure by adding seperator keyword in csv reader in tester * Deep Learning from Scikit-Learn (#547) * add Multi-layer perceptron classifier and regressor into raven * add tests for multi-layer perceptron neural network * add manuals * modify input files to avoid regold * fix typos and update scikit-learn versions * rework: Raven-runs-raven with ROM (#548) * fixed time-dependent SKL ROM, added test * slight regold in 5th sigfig for raven runs raven case * rework: MOOSE submodule update (#550) * update to latest moose master, includes test harness failure improvements * reverted QA verson of sklearn to 0.18 (#552) * fixed rrr example plugin test (#558) * fix library version for skl (#559) * Hierarchical and DET for new DataObject (#532) * fixed a portion of enesemble model * added check for consistency for shape in indexes * added unit test for checking index/var shapes * fixed custom sampler * updated revision * addressed Hier issue * fixed Hierachical and DET tests (no adaptive yet) * skiped a portion of the unit test since it is not finished yet * fixed new modification in XSD * addressed Paul and Conjiang's comments * fixed MAAP5interfaceAHDETSampling and MAAP5interfaceADETSampling * fixed framework/user_guide/ravenTutorial.singleRunPlot, framework/user_guide/ravenTutorial.singleRunSubPlot, framework/user_guide/ravenTutorial.RomLoad * fixed user_guide heavy tests * fixed start * added ext report codes * addressed Congjian comments (1of2) * added documentation for hirarchical flag * rework update cashflow (#560) * updated CashFlow submodule id * Code Clean Up (#567) * clean up reassignSampledVarsPbToFullyCorrVars, because we add it to the Sampler base class * move reassignPbWeightToCorrelatedVars to Sampler base class * fix comments for PR#560 * fix pb in Monte Carlo and fix generic code interface test * fix cluster tests (#566) * fix cluster tests * fix parallelPP test * Alfoa/dataobject rework finalize ensemble (#565) * Closes #541 * Update GenericCodeInterface.py * fixed tester (#528) * ensemble model pb weights for variables coming from functions * fixed single-value-duplication error for SKL ROMs (#555) * fixed single-value-duplication error * fixed test framework/ensembleModelTests.testEnsembleModelWith2CodesAndAliasAndOptionalOutputs * modified order of input output to avoid regolding * Reducing DataObject Attribute Functionality (#278) * Enabling the data attribute tests and fixing the operators for PointSets. TODO: Break the data_attributes test down to be more granular and fix the outputPivotValue on the HistorySets. * Splitting the test files for the DataObject attributes and correcting some malformations in the subsequent input files. TODO: Fix the attributes for the history set when operating from a Model. * Fixing HistorySet data attribute test case to look for the correct file. * Correcting attributions for data object tests. maljdan had only moved the files. The original tests were designed by others. TODO: verify if test results are valid or the result of incorrect gold files. * Reducing the number of DataObjects needed in the shared suite of DataObject attribute tests. * Regolding the DataObject HistorySet attributes files to respect the outputPivotVal specified for stories2. * Picking up where I left off, trying to recall what modifications still need to be done to the HistorySet. * Regolding a test case on data attributes, removing dead code from the HistorySet and updating some aspects of the PointSet. * Removing data attribute feature set with explanation in comments. Cleaning old code. * Regolding fixed test case. * Reverting changes to ensemble test and accommodating unstructured inputs. * addressed misunderstanding in HistorySet * added HSToPSOperator PP * added documentation for new interface * finished new PP * addressed first comments * addressed Congjian's comments * updated XSD * moving ahead * fixed test framework/ensembleModelTests.testEnsembleModelLinearThreadWithTimeSeries * fixed framework/ensembleModelTests.testEnsembleModelLinearParallelWithOptimizer * fixed framework/CodeInterfaceTests.DymolaTestTimeDepNoExecutableEnsembleModel * fixed framework/PostProcessors/InterfacedPostProcessor.metadataUsageInInterfacePP * fixed new test files coming from devel * updated InterfacedPP HStoPSOperator * fixed xsd * added documenation for DataSet * added conversion script from old HDF5 to new HDF5 * Update DataObjects.xsd * remove white space * Update database_data.tex * Update postprocessor.tex * removed unuseful __init__ in Melcor interface * addressed Congjian's comments * ok * moving * moving ahead * ok * moving * aaaa * ok * a * CSV printing speedup (#570) * Closes #541 * Update GenericCodeInterface.py * fixed * fixed tester (#528) * ensemble model pb weights for variables coming from functions * fixed single-value-duplication error for SKL ROMs (#555) * fixed single-value-duplication error * xsd * fixed type * fixed test framework/ensembleModelTests.testEnsembleModelWith2CodesAndAliasAndOptionalOutputs * modified order of input output to avoid regolding * ok * Reducing DataObject Attribute Functionality (#278) * Enabling the data attribute tests and fixing the operators for PointSets. TODO: Break the data_attributes test down to be more granular and fix the outputPivotValue on the HistorySets. * Splitting the test files for the DataObject attributes and correcting some malformations in the subsequent input files. TODO: Fix the attributes for the history set when operating from a Model. * Fixing HistorySet data attribute test case to look for the correct file. * Correcting attributions for data object tests. maljdan had only moved the files. The original tests were designed by others. TODO: verify if test results are valid or the result of incorrect gold files. * Reducing the number of DataObjects needed in the shared suite of DataObject attribute tests. * Regolding the DataObject HistorySet attributes files to respect the outputPivotVal specified for stories2. * Picking up where I left off, trying to recall what modifications still need to be done to the HistorySet. * Regolding a test case on data attributes, removing dead code from the HistorySet and updating some aspects of the PointSet. * Removing data attribute feature set with explanation in comments. Cleaning old code. * Regolding fixed test case. * Reverting changes to ensemble test and accommodating unstructured inputs. * addressed misunderstanding in HistorySet * added HSToPSOperator PP * added documentation for new interface * finished new PP * addressed first comments * addressed Congjian's comments * updated XSD * moving ahead * fixed test framework/ensembleModelTests.testEnsembleModelLinearThreadWithTimeSeries * last one almost done * fixed framework/ensembleModelTests.testEnsembleModelLinearParallelWithOptimizer * fixed framework/CodeInterfaceTests.DymolaTestTimeDepNoExecutableEnsembleModel * almost done * fixed framework/PostProcessors/InterfacedPostProcessor.metadataUsageInInterfacePP * fixed new test files coming from devel * updated InterfacedPP HStoPSOperator * fixed xsd * added documenation for DataSet * added conversion script from old HDF5 to new HDF5 * Update DataObjects.xsd * remove white space * Update database_data.tex * testing printing * reverted to_csv for ND dataset. Need a good test for multiple-index dataset printing. * added benchmark results for numpy case * Rework Ensemble for Indexes (#571) * got the test case working WITH picard iteration, now working to sort it out so picard is not used * works without picard * cleanup * fix for single residual values * order change for xsd sake * added user guide entry, added some slight additional testing * gold file * adding stuff * xsd fix * stash for syncing * added tips and tricks in docs * cleanup * some comments addressed * changed all raven entities to use UpperCaseCapitalization in sentences * ok * try * finished DMD * Alfoa/performance improvement ensemble model (#581) * removed piclking of TargetEvaluation * removed pickling of Optional Outputs and removed specialization in the Step for ensembleModel * changed name of local target evaluation * changed name of local target evaluation * addressed Congjian's comments and all execpt one of Paul's ones * fixed remove in assembler * Talbpaul/rework maxqsize (#584) * Closes #541 * Update GenericCodeInterface.py * fixed * fixed tester (#528) * ensemble model pb weights for variables coming from functions * stash * fixed failing tests by adding maxqueuesize back to 1 * test revisions added * revision author name * fixed conflicts (#595) * fixed conflicts * fixed typo * fixed one of the categorical cases * fixed restart * library fixes * fixed netcdf4 specification * fixing numpy version again * trying numpy 1.14 * numpy 1.11 * test for missing variables in restart added * numpy 1.14.0 * 1.14 with inclusion in conda list * Update existing_interfaces.tex * restarting with more conda version checking * Skipping ARMA reseed test * [rework] ExternalXML in RAVEN Code Interface (#596) * Closes #541 * Update GenericCodeInterface.py * fixed * fixed tester (#528) * ensemble model pb weights for variables coming from functions * cherry picking, test is not passing * fixed merge for rework * Optimizer inherits from Sampler (#600) * Job Profiling (#586) * implements job profiling * review comments * locking down xarray library versions * library change * pandas version lock * shuffled libraries according to discussion, pinned netcdf4 * trying pip package specs * changed the printing strategy of profiles (#601) * changed the printing strategy of profiles * Update Runner.py * added constant reading into solution export, also added test to verbosity test * removed debug prints * dummy change to run tests * modified spline...almost done * moving forward for Crow * ok * almost done * ok * Add "long" data type compatability (#590) * Closes #541 * Update GenericCodeInterface.py * fixed * fixed tester (#528) * ensemble model pb weights for variables coming from functions * added long to integer options, added unit test coverage * version control * testing library versions in RavenUtils * found consistent library set * revert utils changes * patched up file closing for Windows * moved 2 tests to unordered csv * remove directory printing for history sets * removed path from history set CSVs * added verbosity for crosschecking * temporarily skipping time warping cluster tests due to Windows failures * returned outstream main printing * reducing strictness of user guide forward grid sampling test * fixed rel err in unordered csv differ * working out bugs for UnorderedCSVDiffer * tests passing, had to introduce zero threshold for two basic stats tests * increased debugging verbosity for debugging linux failures * faster version of thresholding, think it works for all types * now with less debug * fixed nested XML reading (#603) * finished fit for Spline * aaa * Fixes optimizer-runs-raven bug (#610) * commented out initial setting of point probability to prevent unintended downstream interactions * added verbosity to potential type failing, and regolded new prefixes (other values did not change) * added a test * added second test for spline interpolator * ok now working on DMD * Rw data final naming (#614) * relocated utils, dataobject unit tests and renamed dataobjects * relocated Files and Distributions unit tests as well * copied necessary files back to main test dir * ok * Alfoa/scale6.2 (#608) * added the parser * moving * ok * finished interface * added test + initial documentation * added documentation for SCALE coupling * missing regression tests * addressed Diego's comments * added test for Combine TRITON and ORIGEN * added test for combined triton origen + added possibility in CustomSampler to use the functions * addressed diego comments again * revert old commit and address Diego's final comments * type in tests file * added prereq in testExternalReseed to avoid conflict in parallel test execution * updated XSD schema * reset moose * cleaning up * stash * Improved UnorderedCSVDiffer speed (#615) * cleaned up * cleanup * checked out dataobject-rework tests file * correlated data generator and example csv * adding printing * stash * ok * moving * added math utils * starting on independent multitarget arma * moving ahead * almost done * moving * ok * ok * added description * removed CSVs and added documentation * reverted modificaiton in basic stats * added test for PolyExponential * missing test for DMD * added tests for DMD * addressed Diego's comments * added <revision> in TestInfo * regolded PolyExponential tests since I shortened the time series * added format for printinig * tolerances * fixed coeff printing on scree for polyExp Poly * added minimum scipy version * remove xml checker for DMD since the eigenvalues are not necessary ordered and consequentially a spurious diff can happen * type * added importe of differential_evolution only where is required * modified tests * expand install script for conda 4.4 and beyond (#618) * expand install script for conda 4.4 and beyond * added explanatory comments * Multi-sample Variables (vector inputs) (#625) * Optimizer inherits from Sampler * first implementation: by default copy value to all entries in vector variable, works * finished test and implementation of simple repeat-value vector variable sampling * added InputSpecs for optimizer, tests pass * got input params working for optimizer * first implementation: by default copy value to all entries in vector variable, works * finished test and implementation of simple repeat-value vector variable sampling * added InputSpecs for optimizer, tests pass * got input params working for optimizer * stash * fixed gradient calculation to include vectors, all non-vector tests passing * fixed gradient calculation to include vectors, all non-vector tests passing, conditional sizing for vector grad * boundary condition checking, all passing * redundant trajectories, all passing * same coordinate check * dot product step sizing * stochastic engine is incorrectly sized; currently each entry in vector is being perturbed identically. Needs work. * working on constraints, convergence is really poor, needs more help * first boundary conditions (internal) working, although type change in precond test * constraints fully done, only precond has a problem still, vector still not converging well * debugging difference between all scalars and vector * vector * time parabola model * fixed initial step size * working, although as a vector is a bit slower than all scalars * vector is faster than scalar, reduced scale of tests (and better solution) * all passing, but precond, which is having the type error still * cleaned up, removed scalar comparison test, fixed precond test * cleanup * last bit of cleanup, all tests passing * stash, it appears customsampler and datasets are not yet compatible * xsd * stash, <what> cannot handle specific requests * reloading from dataset csv works be default * fixed unit test, vector test * xsd * CustomSampler handles Point,History,Data sets * cleanup * cleanup * updated custom sampler description docs * Optimizer uses Custom sampler with vector variables for initial points * unnecessarily-tested file * initial round of review comments * script for disclaimer adding, also added to models in optimizing test dir * increased verbosity for test debug * more verbosity for debugging * gold standard agrees with all test machines, personal cluster profile (my desktop find minimum in traj 1 of 36 instead of 220ish) * new golds * exposed RNG to RAVEN python...swig (#630) * exposed RNG to RAVEN python...swig * fixed for now dist stoch enviroment * Vector constants (#632) * shape from node to attribute * constants can now be vectors too * necessary Sampler and Optimizer changes * extracted common constant reading for sampler, optimizer * including string custom vector vars * vector constant works in rrr with optimizer * initial splitting of SVL by class * split out SVL done, tests pass * added statsmodels, added multitarget independent, tested single target still works * multiple independent ARMA targets test * stash * new arma noise is too large compared to old one; get it from normed data or not * new ARMA working fine * test very similar but not quite the same as original, mean is improved * test relocation * updated multiple arma for statsmodels operation * tests passing * added start of varma test * pre-merge review comments addressed: framework/DataObjects (#646) * pre-merge review comments addressed for modules in framework/DataObjects, with the exception of merging DataObject into DataSet * removed hierarchal unecessary use of [:] * remainder of comments addressed * test, documentation, implementation all in place * not ready for unit test yet * fixed missing tests * typo * modified test for dataobject rework * added documentations for the last 29 tests were not documented * ok * type * Closes #68 * added verbosity in all the XSD s * fixed None global attribute for verbosity setting * fixed BaseClass if statment in checking for global attribute argument * more cleaning * added statsmodels to conda list * regolding for right initial point * fix for single fourier, duplicated fourier bases * loosening tolerance for base arma test * playing with tolerances * regolding for common solution among test machines * regolded on test machine * tolerance based on mac vs linux diff * still trying * added burning to ARMA (but not varma) * integer number of burnins * regolded from results on desktop mac as a result of burnins * update to allow pivotParameter to be specified * trying seeding of numpy as well as crow * updated relative match for ARMA tests * reverting default numpy seeding change; it caused lots of tests to fail * a little more * barely worth testing * checking statistics on base arma * missing gold file * fixed tolerance * removed default pivot * varma to statistical test * varma tests outputs only, needs independent rng * updated test to use controlled correlated data, and now controlling varma noise generation I think * gold file * fixed RNG for initial state * updated for increased bins * stats test for varma * more realistic test metric * longer history for better statistics * changes to split supervised learning to keep up with PR 674 * typo * updated module docstrings
alfoa
pushed a commit
that referenced
this pull request
Oct 18, 2018
* added test files * edits * test for expanded ET * Non-multilevel Optimizers reworked (#507) * optimizers passing with the new DataObjects except multilevel * Alfoa/data object rework (#509) * fixed CustomSampler * fixed test_output for new version of matplotlib * added files * edits * Alfoa/test fix (#525) * added _reassignSampledVarsPbToFullyCorrVars to Sampler base class. * Script now offers a flag to change ignored files (#508) -e can be followed by a comma separated list of directories or files which will be ignored. Old behavior is to only ignore .git. New default is .git and raven. * fixed run_tests * Framework in makefile (#520) * Added hit to all requirements and clean * Now bindings instead of binary * Moves hit.so to usable location * fixed another parsing error in tests file for framework/PostProcessors/TemporalDataMiningPostProcessor/Clustering.GaussianMixture * added new ID of moose with fix on TestHarness * fixed make file for windows * rework: test harness fix (#526) * fixed test harness to remove output files * Asynchronous History Sampling (#511) * fixed adding histories of different lengths through addRealization * fixed restart MC typo * Fix data mining for the new data object (#512) * edit * edits * initial fix for data mining pp * fix plot and pca * fix plot and HS2PS * fix temporal data mining pp * fix time-dep data mining based on dimensionality reduction * fix dataobjectfilter pp and datamining pp * regold tests, because label switches, and change of prints * addition regold * regold pca * fix comments * fix more comments * fix time-dep basic statistics pp and history set sync pp (#515) * fix time-dep basic statistics pp and history set sync pp * add regold files * fixed internal parallel test for PP (#521) * update user manual for several post-processors (#523) * update documents for basic statistics pp * update documents for metric and cross validation pp * update documents for ImportanceRank pp * update documents for external post-processor * update documents for data mining post processor * resolve comments * rework: raven running raven (#522) * Script now offers a flag to change ignored files (#508) -e can be followed by a comma separated list of directories or files which will be ignored. Old behavior is to only ignore .git. New default is .git and raven. * test added * improving analytic test doc * Generalized typechecking (#524) * isAType and unit tests * converted dataobjects to use mathutils typechecking * edits * regold historysetsyn tests (#529) * starting working on DET * Fix clustering with DTW and ETImporter PP (#531) * fix solution export in Temporal data mining * fix ETImporter and regold AffinityPropogation * fix dtw * External Model collection fix (#534) * fixed external model and added a complexity test * fixed external model to catch more variables * Alfoa/incorrect test files (#535) * fixed inccorect tests * fixed custom mode * removed unuseful stuff * added regold file * fixed AdaptiveBatch test files * fixed test_Custom_Sampler_DataObject.xml * fixes (#533) *Fix interface pp for risk measure * Fix xsd and PostProcess in raven tutorial (#536) * fix postprocess test in the user_guide * fix xsd * comment out the postprocess output * fixed gold file for getpot test (#539) * rework: Multilevel optimizers (#537) * fixed external model and added a complexity test * fixed external model to catch more variables * fixed pathing * fixed infinite missing file * optimizer tests working * rework: CSV fixes and improvements (#538) * loading from dict or CSV now extends existing data instead of replacing it * fixed multiple history csv loading * added failure check test * added files * edits * initial implementation of markov categorical distribution * rework: added libs to conda setup (#542) * added xarray, netcdf4 * trying to fix moosebuild failure by adding seperator keyword in csv reader in tester * edits * edits * Deep Learning from Scikit-Learn (#547) * add Multi-layer perceptron classifier and regressor into raven * add tests for multi-layer perceptron neural network * add manuals * modify input files to avoid regold * fix typos and update scikit-learn versions * rework: Raven-runs-raven with ROM (#548) * fixed time-dependent SKL ROM, added test * slight regold in 5th sigfig for raven runs raven case * rework: MOOSE submodule update (#550) * update to latest moose master, includes test harness failure improvements * compute the steady state probability * reverted QA verson of sklearn to 0.18 (#552) * edit * add gold files, fix parser error * update tests * add python module for external model * edits * edits * edits * fixed rrr example plugin test (#558) * fix library version for skl (#559) * edits * edits * edits * initial implement for DataClassifier postprocessor * update functions * update test * edits * update tests, fix typos, add gold files * added paper * add the capability to handle input with type of HistorySet * edits * add documents for DataClassifier pp * edit * edits * Hierarchical and DET for new DataObject (#532) * fixed a portion of enesemble model * added check for consistency for shape in indexes * added unit test for checking index/var shapes * fixed custom sampler * updated revision * addressed Hier issue * fixed Hierachical and DET tests (no adaptive yet) * skiped a portion of the unit test since it is not finished yet * fixed new modification in XSD * addressed Paul and Conjiang's comments * fixed MAAP5interfaceAHDETSampling and MAAP5interfaceADETSampling * fixed framework/user_guide/ravenTutorial.singleRunPlot, framework/user_guide/ravenTutorial.singleRunSubPlot, framework/user_guide/ravenTutorial.RomLoad * fixed user_guide heavy tests * fixed start * added ext report codes * addressed Congjian comments (1of2) * added documentation for hirarchical flag * rework update cashflow (#560) * updated CashFlow submodule id * Code Clean Up (#567) * clean up reassignSampledVarsPbToFullyCorrVars, because we add it to the Sampler base class * move reassignPbWeightToCorrelatedVars to Sampler base class * fix comments for PR#560 * fix pb in Monte Carlo and fix generic code interface test * fix cluster tests (#566) * fix cluster tests * fix parallelPP test * Alfoa/dataobject rework finalize ensemble (#565) * Closes #541 * Update GenericCodeInterface.py * fixed tester (#528) * ensemble model pb weights for variables coming from functions * fixed single-value-duplication error for SKL ROMs (#555) * fixed single-value-duplication error * fixed test framework/ensembleModelTests.testEnsembleModelWith2CodesAndAliasAndOptionalOutputs * modified order of input output to avoid regolding * Reducing DataObject Attribute Functionality (#278) * Enabling the data attribute tests and fixing the operators for PointSets. TODO: Break the data_attributes test down to be more granular and fix the outputPivotValue on the HistorySets. * Splitting the test files for the DataObject attributes and correcting some malformations in the subsequent input files. TODO: Fix the attributes for the history set when operating from a Model. * Fixing HistorySet data attribute test case to look for the correct file. * Correcting attributions for data object tests. maljdan had only moved the files. The original tests were designed by others. TODO: verify if test results are valid or the result of incorrect gold files. * Reducing the number of DataObjects needed in the shared suite of DataObject attribute tests. * Regolding the DataObject HistorySet attributes files to respect the outputPivotVal specified for stories2. * Picking up where I left off, trying to recall what modifications still need to be done to the HistorySet. * Regolding a test case on data attributes, removing dead code from the HistorySet and updating some aspects of the PointSet. * Removing data attribute feature set with explanation in comments. Cleaning old code. * Regolding fixed test case. * Reverting changes to ensemble test and accommodating unstructured inputs. * addressed misunderstanding in HistorySet * added HSToPSOperator PP * added documentation for new interface * finished new PP * addressed first comments * addressed Congjian's comments * updated XSD * moving ahead * fixed test framework/ensembleModelTests.testEnsembleModelLinearThreadWithTimeSeries * fixed framework/ensembleModelTests.testEnsembleModelLinearParallelWithOptimizer * fixed framework/CodeInterfaceTests.DymolaTestTimeDepNoExecutableEnsembleModel * fixed framework/PostProcessors/InterfacedPostProcessor.metadataUsageInInterfacePP * fixed new test files coming from devel * updated InterfacedPP HStoPSOperator * fixed xsd * added documenation for DataSet * added conversion script from old HDF5 to new HDF5 * Update DataObjects.xsd * remove white space * Update database_data.tex * Update postprocessor.tex * removed unuseful __init__ in Melcor interface * addressed Congjian's comments * ok * moving * moving ahead * ok * moving * aaaa * ok * a * CSV printing speedup (#570) * Closes #541 * Update GenericCodeInterface.py * fixed * fixed tester (#528) * ensemble model pb weights for variables coming from functions * fixed single-value-duplication error for SKL ROMs (#555) * fixed single-value-duplication error * xsd * fixed type * fixed test framework/ensembleModelTests.testEnsembleModelWith2CodesAndAliasAndOptionalOutputs * modified order of input output to avoid regolding * ok * Reducing DataObject Attribute Functionality (#278) * Enabling the data attribute tests and fixing the operators for PointSets. TODO: Break the data_attributes test down to be more granular and fix the outputPivotValue on the HistorySets. * Splitting the test files for the DataObject attributes and correcting some malformations in the subsequent input files. TODO: Fix the attributes for the history set when operating from a Model. * Fixing HistorySet data attribute test case to look for the correct file. * Correcting attributions for data object tests. maljdan had only moved the files. The original tests were designed by others. TODO: verify if test results are valid or the result of incorrect gold files. * Reducing the number of DataObjects needed in the shared suite of DataObject attribute tests. * Regolding the DataObject HistorySet attributes files to respect the outputPivotVal specified for stories2. * Picking up where I left off, trying to recall what modifications still need to be done to the HistorySet. * Regolding a test case on data attributes, removing dead code from the HistorySet and updating some aspects of the PointSet. * Removing data attribute feature set with explanation in comments. Cleaning old code. * Regolding fixed test case. * Reverting changes to ensemble test and accommodating unstructured inputs. * addressed misunderstanding in HistorySet * added HSToPSOperator PP * added documentation for new interface * finished new PP * addressed first comments * addressed Congjian's comments * updated XSD * moving ahead * fixed test framework/ensembleModelTests.testEnsembleModelLinearThreadWithTimeSeries * last one almost done * fixed framework/ensembleModelTests.testEnsembleModelLinearParallelWithOptimizer * fixed framework/CodeInterfaceTests.DymolaTestTimeDepNoExecutableEnsembleModel * almost done * fixed framework/PostProcessors/InterfacedPostProcessor.metadataUsageInInterfacePP * fixed new test files coming from devel * updated InterfacedPP HStoPSOperator * fixed xsd * added documenation for DataSet * added conversion script from old HDF5 to new HDF5 * Update DataObjects.xsd * remove white space * Update database_data.tex * testing printing * reverted to_csv for ND dataset. Need a good test for multiple-index dataset printing. * added benchmark results for numpy case * Rework Ensemble for Indexes (#571) * got the test case working WITH picard iteration, now working to sort it out so picard is not used * works without picard * cleanup * fix for single residual values * order change for xsd sake * added user guide entry, added some slight additional testing * gold file * adding stuff * xsd fix * stash for syncing * added tips and tricks in docs * cleanup * some comments addressed * changed all raven entities to use UpperCaseCapitalization in sentences * ok * try * finished DMD * edit ensemble test * Alfoa/performance improvement ensemble model (#581) * removed piclking of TargetEvaluation * removed pickling of Optional Outputs and removed specialization in the Step for ensembleModel * changed name of local target evaluation * changed name of local target evaluation * addressed Congjian's comments and all execpt one of Paul's ones * fixed remove in assembler * graph time dep * graph time dep * ET TD * add missing files * resolve comments * edits * Talbpaul/rework maxqsize (#584) * Closes #541 * Update GenericCodeInterface.py * fixed * fixed tester (#528) * ensemble model pb weights for variables coming from functions * stash * fixed failing tests by adding maxqueuesize back to 1 * test revisions added * revision author name * edits * added temporary walltime for codes * edits * fixed conflicts (#595) * fixed conflicts * fixed typo * fixed one of the categorical cases * fixed restart * library fixes * fixed netcdf4 specification * fixing numpy version again * trying numpy 1.14 * numpy 1.11 * test for missing variables in restart added * numpy 1.14.0 * 1.14 with inclusion in conda list * Update existing_interfaces.tex * restarting with more conda version checking * Skipping ARMA reseed test * [rework] ExternalXML in RAVEN Code Interface (#596) * Closes #541 * Update GenericCodeInterface.py * fixed * fixed tester (#528) * ensemble model pb weights for variables coming from functions * cherry picking, test is not passing * fixed merge for rework * Optimizer inherits from Sampler (#600) * Job Profiling (#586) * implements job profiling * review comments * locking down xarray library versions * library change * pandas version lock * shuffled libraries according to discussion, pinned netcdf4 * trying pip package specs * changed the printing strategy of profiles (#601) * changed the printing strategy of profiles * Update Runner.py * added constant reading into solution export, also added test to verbosity test * removed debug prints * dummy change to run tests * modified spline...almost done * moving forward for Crow * ok * almost done * ok * Add "long" data type compatability (#590) * Closes #541 * Update GenericCodeInterface.py * fixed * fixed tester (#528) * ensemble model pb weights for variables coming from functions * added long to integer options, added unit test coverage * version control * testing library versions in RavenUtils * found consistent library set * revert utils changes * patched up file closing for Windows * moved 2 tests to unordered csv * remove directory printing for history sets * removed path from history set CSVs * added verbosity for crosschecking * temporarily skipping time warping cluster tests due to Windows failures * returned outstream main printing * reducing strictness of user guide forward grid sampling test * fixed rel err in unordered csv differ * working out bugs for UnorderedCSVDiffer * tests passing, had to introduce zero threshold for two basic stats tests * increased debugging verbosity for debugging linux failures * faster version of thresholding, think it works for all types * now with less debug * fixed nested XML reading (#603) * finished fit for Spline * aaa * Fixes optimizer-runs-raven bug (#610) * commented out initial setting of point probability to prevent unintended downstream interactions * added verbosity to potential type failing, and regolded new prefixes (other values did not change) * added a test * added second test for spline interpolator * ok now working on DMD * Rw data final naming (#614) * relocated utils, dataobject unit tests and renamed dataobjects * relocated Files and Distributions unit tests as well * copied necessary files back to main test dir * ok * Alfoa/scale6.2 (#608) * added the parser * moving * ok * finished interface * added test + initial documentation * added documentation for SCALE coupling * missing regression tests * addressed Diego's comments * added test for Combine TRITON and ORIGEN * added test for combined triton origen + added possibility in CustomSampler to use the functions * addressed diego comments again * revert old commit and address Diego's final comments * type in tests file * added prereq in testExternalReseed to avoid conflict in parallel test execution * updated XSD schema * reset moose * cleaning up * Improved UnorderedCSVDiffer speed (#615) * cleaned up * cleanup * checked out dataobject-rework tests file * adding printing * ok * edits * moving * PRA plugin manual first edits * added math utils * edits * moving ahead * edits * add manual for the DataClassifier in PRAPlugin * almost done * edits * edit * moving * add manual for markov categorical distribution * edit * ok * edits * ok * added description * removed CSVs and added documentation * reverted modificaiton in basic stats * edits * edits * edits * edits * removed files * removed files * added test for PolyExponential * missing test for DMD * added tests for DMD * addressed Diego's comments * added <revision> in TestInfo * regolded PolyExponential tests since I shortened the time series * added format for printinig * tolerances * fixed coeff printing on scree for polyExp Poly * added minimum scipy version * remove xml checker for DMD since the eigenvalues are not necessary ordered and consequentially a spurious diff can happen * type * added importe of differential_evolution only where is required * modified tests * update test for markov distribution * added comments * expand install script for conda 4.4 and beyond (#618) * expand install script for conda 4.4 and beyond * added explanatory comments * edits * change the data classifier to use the new structure of DataObjects * added missing files * Multi-sample Variables (vector inputs) (#625) * Optimizer inherits from Sampler * first implementation: by default copy value to all entries in vector variable, works * finished test and implementation of simple repeat-value vector variable sampling * added InputSpecs for optimizer, tests pass * got input params working for optimizer * first implementation: by default copy value to all entries in vector variable, works * finished test and implementation of simple repeat-value vector variable sampling * added InputSpecs for optimizer, tests pass * got input params working for optimizer * stash * fixed gradient calculation to include vectors, all non-vector tests passing * fixed gradient calculation to include vectors, all non-vector tests passing, conditional sizing for vector grad * boundary condition checking, all passing * redundant trajectories, all passing * same coordinate check * dot product step sizing * stochastic engine is incorrectly sized; currently each entry in vector is being perturbed identically. Needs work. * working on constraints, convergence is really poor, needs more help * first boundary conditions (internal) working, although type change in precond test * constraints fully done, only precond has a problem still, vector still not converging well * debugging difference between all scalars and vector * vector * time parabola model * fixed initial step size * working, although as a vector is a bit slower than all scalars * vector is faster than scalar, reduced scale of tests (and better solution) * all passing, but precond, which is having the type error still * cleaned up, removed scalar comparison test, fixed precond test * cleanup * last bit of cleanup, all tests passing * stash, it appears customsampler and datasets are not yet compatible * xsd * stash, <what> cannot handle specific requests * reloading from dataset csv works be default * fixed unit test, vector test * xsd * CustomSampler handles Point,History,Data sets * cleanup * cleanup * updated custom sampler description docs * Optimizer uses Custom sampler with vector variables for initial points * unnecessarily-tested file * initial round of review comments * script for disclaimer adding, also added to models in optimizing test dir * increased verbosity for test debug * more verbosity for debugging * gold standard agrees with all test machines, personal cluster profile (my desktop find minimum in traj 1 of 36 instead of 220ish) * new golds * exposed RNG to RAVEN python...swig (#630) * exposed RNG to RAVEN python...swig * fixed for now dist stoch enviroment * added more missing files * missing files more * added last file * edits * edits * updated xsd * fix xsd for Markov categorical distribution * remove duplicated lines * remove duplicated lines * edits * edits * edits * Vector constants (#632) * shape from node to attribute * constants can now be vectors too * necessary Sampler and Optimizer changes * extracted common constant reading for sampler, optimizer * including string custom vector vars * vector constant works in rrr with optimizer * fix data classifier for HistorySet * fix typo * delete trailing whitespace * edits * pre-merge review comments addressed: framework/DataObjects (#646) * pre-merge review comments addressed for modules in framework/DataObjects, with the exception of merging DataObject into DataSet * removed hierarchal unecessary use of [:] * remainder of comments addressed * modified test for dataobject rework * fixes * edits after first round of review * removed useless files * cleaned files * removed keyword * modified docs * edits * edits * edits * edits * rm dataFile for MarkovCategorical dist, fix code to handle MAAP5 interface without executable * fix seeding for markov model * fix test for data classifier * resolve part of the comments * update raven user manual * capitalize the class name * update docs * update docs build * rename files * update FT tests * update ET tests * update class name * fix data object * merge documents for ETImportor PP * merge documents of DataClassifier and FTImporter PP * fix markov model with internal RNG class, and regold tests due to merge devel with issue #672 * first round of reseolved comments * delete whitespaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Should close #589 for the dataobject-rework branch, but we will need to see it pass on Windows especially.
What are the significant changes in functionality due to this change request?
Adds the
longdata type to the acceptable integer data types. Tested through the mathUtils unit tests. The test integer was selected based on a number that was too long to be merely an integer on OS X 10.12.6 using python 2.7.13 64-bit.