Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raven runs Raven on a cluster #684

Merged
merged 36 commits into from
Jul 20, 2018
Merged

Conversation

PaulTalbot-INL
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL commented Jun 12, 2018


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #683

What are the significant changes in functionality due to this change request?
  • Changes the default library activation scripts
  • Increases comment and library environment verbosity
  • Changed directory behavior of cluster runs to mirror local runs
  • Added test to confirm RrR with conversion module works on cluster runs

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?

PaulTalbot-INL and others added 30 commits April 6, 2017 11:16
@moosebuild
Copy link

Job Test linux on 6ce1346 : invalidated by @PaulTalbot-INL

unexpected "make" fail

@moosebuild
Copy link

All jobs on 6ce1346 : invalidated by @PaulTalbot-INL

CIVET updates via #668

@moosebuild
Copy link

Job Test mac on 1cd38d2 : invalidated by @PaulTalbot-INL

unusual build error

@moosebuild
Copy link

Job Test mac on 1cd38d2 : invalidated by @PaulTalbot-INL

two instances of civet were running in same environment

removed unused import "sys" in file MPISimulationMode.py
@alfoa
Copy link
Collaborator

alfoa commented Jul 20, 2018


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code. OK
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts). N/A
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details. OK
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass. Passed
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True. OK
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync. n/a
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done. RrR on Cluster #683
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added? n/a

@alfoa
Copy link
Collaborator

alfoa commented Jul 20, 2018

Checklist passed....waiting for the tests to pass...

@alfoa
Copy link
Collaborator

alfoa commented Jul 20, 2018

Check list passed...
Issue closure list passed...

Merging...

@alfoa alfoa merged commit 4603c46 into idaholab:devel Jul 20, 2018
@PaulTalbot-INL PaulTalbot-INL deleted the rrr-cluster branch April 8, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RrR on Cluster
4 participants