Alfoa/issue780 ls #781

alfoa · 2018-09-12T00:02:54Z

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #780

What are the significant changes in functionality due to this change request?

Just restoring the old functionality of assigning an arbitrary group name in case the prefix is not passed to the HDF5

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

1. Review all computer code.
2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
8. If an analytic test is changed/added is the the analytic documentation updated/added?

`ch 'devel' of https://github.com/idaholab/raven into devel

wangcj05 · 2018-09-12T14:57:54Z

framework/h5py_interface_creator.py

@@ -186,7 +186,12 @@ def addGroup(self,rlz):
      @ Out, None
    """
    parentID  = rlz.get("RAVEN_parentID",[None])[0]
-    groupName = str(rlz.get("prefix")[0] if not isinstance(rlz.get("prefix"),basestring) else rlz.get("prefix"))
+    prefix    = rlz.get("prefix")


The issue in #780 complains that rlz is None, the changes here did not reflect this. Could you explain it?

Sure. The issue reports a failure in the following line:

groupName = str(rlz.get("prefix")[0] if not isinstance(rlz.get("prefix"),basestring) else rlz.get("prefix"))

The reason was that since some of the adaptive samplers/optimizers construct a solution export DataObject without a prefix for each realization, the rlz.get("prefix") was returning None (not found keyword "prefix"). Now since the old machine was either expecting the prefix to be a string (basestring) or a list, it was falling in the "not string case" so trying to access to rlz.get("prefix")[0] but the ruturn case was not a string not because it was a list but because it was None.

Got it. Thanks.

moosebuild · 2018-09-12T15:32:41Z

Job Test CentOS 6 on 0c91776 : invalidated by @msgambati-INL

Testing new module only install with MOOSE_JOBS variable configured

moosebuild · 2018-09-12T19:10:27Z

Job Test CentOS 6 on 0c91776 : invalidated by @msgambati-INL

Testing new module only install with MOOSE_JOBS variable configured

moosebuild · 2018-09-12T21:31:02Z

Job Test CentOS 6 on 0c91776 : invalidated by @msgambati-INL

Testing new module only install with MOOSE_JOBS variable configured

moosebuild · 2018-09-12T21:41:21Z

Job Test CentOS 6 on 0c91776 : invalidated by @msgambati-INL

Testing new module only install with MOOSE_JOBS variable configured

moosebuild · 2018-09-12T22:27:03Z

Job Test CentOS 6 on 0c91776 : invalidated by @msgambati-INL