Alfoa/generic codeinterface fix #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ch 'devel' of https://github.com/idaholab/raven into devel
PaulTalbot-INL
requested changes
Nov 13, 2018
PaulTalbot-INL
requested changes
Nov 15, 2018
framework/Models/Model.py
Outdated
| #""" | ||
| #prefix = kwargs.get("prefix") | ||
| #uniqueHandler = kwargs.get("uniqueHandler",'any') | ||
| #forceThreads = kwargs.get("forceThreads",False) |
There was a problem hiding this comment.
Can we add a comment explaining why we are saving this material, and on what conditions it can be removed?
framework/Models/PostProcessor.py
Outdated
| ## This may look a little weird, but due to how the parallel python library | ||
| ## works, we are unable to pass a member function as a job because the | ||
| ## pp library loses track of what self is, so instead we call it from the | ||
| ## class and pass self in as the first parameter | ||
| jobHandler.addJob((self, myInput, samplerType, kwargs), self.__class__.evaluateSample, str(0), modulesToImport=self.mods, forceUseThreads=True) | ||
| #jobHandler.addJob((self, myInput, samplerType, kwargs), self.__class__.evaluateSample, str(0), modulesToImport=self.mods, forceUseThreads=True) |
There was a problem hiding this comment.
Same as above, justification for keeping commented code.
…aholab/raven into alfoa/genericCodeinterfaceFix t push :wq :wq `
alfoa
added
the
comments addressed
|
comments addressed |
10 tasks
|
Checklists pass, review complete. Approved for merge provided that tests pass. Note that the qsub tests are currently under revision, and so are not required to pass at the moment. |
|
@PaulTalbot-INL fixed the test. |
PaulTalbot-INL
approved these changes
Nov 16, 2018
|
New changes approved, tests passing, checklists complete. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #843
What are the significant changes in functionality due to this change request?
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>to True.