Refactor implementations of StructInfo::derive and TypeBuilderAttr #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itchyny
force-pushed
the
refactor-struct-info-derive-builder-attr
branch
3 times, most recently
from
1c32a80
to
6ebf391
Compare
itchyny
force-pushed
the
refactor-struct-info-derive-builder-attr
branch
from
6ebf391
to
6b5e3b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for maintaining this great crate. I was to implement a new feature but noticed that it's hard to reuse
TypeBuilderAttr. I'd like to suggest moveTypeBuilderAttrto a separate file. Also I moved the entire derive implementation to be the public function ofStructInfoand make impl functions private, to make its duty clear.