-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add strip_option(fallback = field_opt)
#150
Conversation
@idanarye maybe I can extend the functionality here to also cover |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some remarks on this. Do you want to fix them? If not, I don't mind doing them myself after merging.
@idanarye should I create a separate PR for |
strip_option(fallback = "field_opt")
strip_option(fallback = field_opt)
Yes, but let's merge this one first. Much of it would probably be the same so lets iron it out once instead of working on the same issues twice. |
I'll create a follow up PR once this is merged. |
Description
Fixes #117 using the API described in #117 (comment).