Show redbox window on JS errors for debug builds

Reviewed By: javache Differential Revision: D4860613 fbshipit-source-id: 255202df9401ffd1dfb48224dd89255eac76874e
idancali · Apr 11, 2017 · abd148f · abd148f
1 parent cb88df0
commit abd148f
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/React/Modules/RCTRedBox.m b/React/Modules/RCTRedBox.m
@@ -368,7 +368,9 @@ - (RCTErrorInfo *)_customizeError:(RCTErrorInfo *)error
 
 - (void)showError:(NSError *)error
 {
-  [self showErrorMessage:error.localizedDescription withDetails:error.localizedFailureReason];
+  [self showErrorMessage:error.localizedDescription
+             withDetails:error.localizedFailureReason
+                   stack:error.userInfo[RCTJSStackTraceKey]];
 }
 
 - (void)showErrorMessage:(NSString *)message
@@ -378,11 +380,15 @@ - (void)showErrorMessage:(NSString *)message
 
 - (void)showErrorMessage:(NSString *)message withDetails:(NSString *)details
 {
+  [self showErrorMessage:message withDetails:details stack:nil];
+}
+
+- (void)showErrorMessage:(NSString *)message withDetails:(NSString *)details stack:(NSArray<id> *)stack {
   NSString *combinedMessage = message;
   if (details) {
     combinedMessage = [NSString stringWithFormat:@"%@\n\n%@", message, details];
   }
-  [self showErrorMessage:combinedMessage withStack:nil isUpdate:NO];
+  [self showErrorMessage:combinedMessage withStack:stack isUpdate:NO];
 }
 
 - (void)showErrorMessage:(NSString *)message withRawStack:(NSString *)rawStack