Skip to content

x_x

x_x #21

Triggered via push December 5, 2023 17:25
Status Failure
Total duration 46s
Artifacts

lint.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

75 errors and 10 warnings
panic message is not a string literal: src/participants.rs#L323
error: panic message is not a string literal --> src/participants.rs:323:26 | 323 | unreachable!(false); | ^^^^^ | = note: this usage of `unreachable!()` is deprecated; it will be a hard error in Rust 2021 = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2021/panic-macro-consistency.html> = note: `#[deny(non_fmt_panics)]` implied by `#[deny(warnings)]` help: add a "{}" format string to `Display` the message | 323 | unreachable!("{}", false); | +++++
`to_string` applied to a type that implements `Display` in `format!` args: src/lib.rs#L738
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/lib.rs:738:15 | 738 | id.to_string(), | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: src/lib.rs#L721
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/lib.rs:721:15 | 721 | id.to_string(), | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: src/lib.rs#L702
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/lib.rs:702:15 | 702 | id.to_string(), | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: src/lib.rs#L683
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/lib.rs:683:15 | 683 | id.to_string(), | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: src/lib.rs#L665
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/lib.rs:665:15 | 665 | id.to_string(), | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: src/lib.rs#L648
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/lib.rs:648:15 | 648 | id.to_string(), | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: src/lib.rs#L631
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/lib.rs:631:15 | 631 | id.to_string(), | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: src/lib.rs#L606
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/lib.rs:606:15 | 606 | id.to_string(), | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: src/lib.rs#L580
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/lib.rs:580:15 | 580 | id.to_string() | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: src/lib.rs#L564
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/lib.rs:564:15 | 564 | id.to_string() | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: src/lib.rs#L552
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/lib.rs:552:15 | 552 | id.to_string(), | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: src/lib.rs#L535
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/lib.rs:535:15 | 535 | id.to_string(), | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: src/lib.rs#L519
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/lib.rs:519:15 | 519 | id.to_string(), | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: src/lib.rs#L502
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/lib.rs:502:15 | 502 | id.to_string(), | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: src/lib.rs#L480
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/lib.rs:480:15 | 480 | id.to_string(), | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
this let-binding has unit value: src/lib.rs#L466
error: this let-binding has unit value --> src/lib.rs:466:9 | 466 | let _: () = serde_json::from_reader(response)?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: omit the `let` binding: `serde_json::from_reader(response)?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value = note: `#[deny(clippy::let_unit_value)]` implied by `#[deny(warnings)]`
`to_string` applied to a type that implements `Display` in `format!` args: src/lib.rs#L462
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/lib.rs:462:15 | 462 | id.to_string() | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: src/lib.rs#L445
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/lib.rs:445:15 | 445 | id.to_string() | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: src/lib.rs#L430
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/lib.rs:430:15 | 430 | id.to_string() | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: src/lib.rs#L366
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/lib.rs:366:66 | 366 | let url = &format!("{}/tournaments/{}.json", API_BASE, id.to_string()); | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: src/lib.rs#L358
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/lib.rs:358:66 | 358 | let url = &format!("{}/tournaments/{}.json", API_BASE, id.to_string()); | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
`to_string` applied to a type that implements `Display` in `format!` args: src/lib.rs#L291
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/lib.rs:291:80 | 291 | reqwest::Url::parse(&format!("{}/tournaments/{}.json", API_BASE, id.to_string())) | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
the borrowed expression implements the required traits: src/lib.rs#L272
error: the borrowed expression implements the required traits --> src/lib.rs:272:40 | 272 | let response = self.client.get(&url).send()?; | ^^^^ help: change this to: `url` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[deny(clippy::needless_borrows_for_generic_args)]` implied by `#[deny(warnings)]`
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L40
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:40:23 | 40 | pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/tournament.rs:296:5 | 296 | builder!(grand_finals_modifier, Option<String>); | ----------------------------------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 40 - pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { 40 + pub fn $field(&mut self, $field: $field_type) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L40
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:40:23 | 40 | pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/tournament.rs:295:5 | 295 | builder!(check_in_duration, u64); | -------------------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 40 - pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { 40 + pub fn $field(&mut self, $field: $field_type) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L40
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:40:23 | 40 | pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/tournament.rs:294:5 | 294 | builder!(signup_cap, u64); | ------------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 40 - pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { 40 + pub fn $field(&mut self, $field: $field_type) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L40
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:40:23 | 40 | pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/tournament.rs:293:5 | 293 | builder!(sequential_pairings, bool); | ----------------------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 40 - pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { 40 + pub fn $field(&mut self, $field: $field_type) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L40
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:40:23 | 40 | pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/tournament.rs:292:5 | 292 | builder!(notify_users_when_the_tournament_ends, bool); | ----------------------------------------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 40 - pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { 40 + pub fn $field(&mut self, $field: $field_type) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L40
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:40:23 | 40 | pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/tournament.rs:291:5 | 291 | builder!(notify_users_when_matches_open, bool); | ---------------------------------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 40 - pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { 40 + pub fn $field(&mut self, $field: $field_type) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L70
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:70:23 | 70 | pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/tournament.rs:290:5 | 290 | builder_so!(game_name); | ---------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder_so` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 70 - pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { 70 + pub fn $field<S: Into<String>>(&mut self, $field: S) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L40
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:40:23 | 40 | pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/tournament.rs:289:5 | 289 | builder!(private, bool); | ----------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 40 - pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { 40 + pub fn $field(&mut self, $field: $field_type) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L40
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:40:23 | 40 | pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/tournament.rs:288:5 | 288 | builder!(show_rounds, bool); | --------------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 40 - pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { 40 + pub fn $field(&mut self, $field: $field_type) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L40
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:40:23 | 40 | pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/tournament.rs:287:5 | 287 | builder!(round_robin_points, GamePoints); | ---------------------------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 40 - pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { 40 + pub fn $field(&mut self, $field: $field_type) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L40
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:40:23 | 40 | pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/tournament.rs:286:5 | 286 | builder!(ranked_by, RankedBy); | ----------------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 40 - pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { 40 + pub fn $field(&mut self, $field: $field_type) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L40
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:40:23 | 40 | pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/tournament.rs:285:5 | 285 | builder!(swiss_rounds, u64); | --------------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 40 - pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { 40 + pub fn $field(&mut self, $field: $field_type) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L40
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:40:23 | 40 | pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/tournament.rs:284:5 | 284 | builder!(swiss_points, GamePoints); | ---------------------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 40 - pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { 40 + pub fn $field(&mut self, $field: $field_type) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L40
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:40:23 | 40 | pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/tournament.rs:283:5 | 283 | builder!(hold_third_place_match, bool); | -------------------------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 40 - pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { 40 + pub fn $field(&mut self, $field: $field_type) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L40
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:40:23 | 40 | pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/tournament.rs:282:5 | 282 | builder!(open_signup, bool); | --------------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 40 - pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { 40 + pub fn $field(&mut self, $field: $field_type) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L50
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:50:23 | 50 | pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/tournament.rs:281:5 | 281 | builder_s!(description); | ----------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder_s` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 50 - pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { 50 + pub fn $field<S: Into<String>>(&mut self, $field: S) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L50
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:50:23 | 50 | pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/tournament.rs:280:5 | 280 | builder_s!(subdomain); | --------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder_s` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 50 - pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { 50 + pub fn $field<S: Into<String>>(&mut self, $field: S) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L50
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:50:23 | 50 | pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/tournament.rs:279:5 | 279 | builder_s!(url); | --------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder_s` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 50 - pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { 50 + pub fn $field<S: Into<String>>(&mut self, $field: S) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L40
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:40:23 | 40 | pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/tournament.rs:278:5 | 278 | builder!(tournament_type, TournamentType); | ----------------------------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 40 - pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { 40 + pub fn $field(&mut self, $field: $field_type) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L50
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:50:23 | 50 | pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/tournament.rs:277:5 | 277 | builder_s!(name); | ---------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder_s` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 50 - pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { 50 + pub fn $field<S: Into<String>>(&mut self, $field: S) -> &mut Self { |
this expression creates a reference which is immediately dereferenced by the compiler: src/tournament.rs#L159
error: this expression creates a reference which is immediately dereferenced by the compiler --> src/tournament.rs:159:30 | 159 | game_tie: remove(&mut map, &format!("{}pts_for_game_tie", prefix))? | ^^^^^^^^ help: change this to: `map` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: src/tournament.rs#L153
error: this expression creates a reference which is immediately dereferenced by the compiler --> src/tournament.rs:153:30 | 153 | game_win: remove(&mut map, &format!("{}pts_for_game_win", prefix))? | ^^^^^^^^ help: change this to: `map` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: src/tournament.rs#L147
error: this expression creates a reference which is immediately dereferenced by the compiler --> src/tournament.rs:147:31 | 147 | match_tie: remove(&mut map, &format!("{}pts_for_match_tie", prefix))? | ^^^^^^^^ help: change this to: `map` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: src/tournament.rs#L141
error: this expression creates a reference which is immediately dereferenced by the compiler --> src/tournament.rs:141:31 | 141 | match_win: remove(&mut map, &format!("{}pts_for_match_win", prefix))? | ^^^^^^^^ help: change this to: `map` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: src/tournament.rs#L134
error: this expression creates a reference which is immediately dereferenced by the compiler --> src/tournament.rs:134:37 | 134 | if let Ok(bye_pts) = remove(&mut map, &format!("{}pts_for_bye", prefix)) { | ^^^^^^^^ help: change this to: `map` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L50
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:50:23 | 50 | pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/participants.rs:51:5 | 51 | builder_s!(misc); | ---------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder_s` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 50 - pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { 50 + pub fn $field<S: Into<String>>(&mut self, $field: S) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L40
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:40:23 | 40 | pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/participants.rs:50:5 | 50 | builder!(seed, u64); | ------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 40 - pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { 40 + pub fn $field(&mut self, $field: $field_type) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L50
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:50:23 | 50 | pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/participants.rs:49:5 | 49 | builder_s!(email); | ----------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder_s` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 50 - pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { 50 + pub fn $field<S: Into<String>>(&mut self, $field: S) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L70
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:70:23 | 70 | pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/participants.rs:48:5 | 48 | builder_so!(challonge_username); | ------------------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder_so` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 70 - pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { 70 + pub fn $field<S: Into<String>>(&mut self, $field: S) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L70
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:70:23 | 70 | pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/participants.rs:47:5 | 47 | builder_so!(name); | ----------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder_so` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 70 - pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { 70 + pub fn $field<S: Into<String>>(&mut self, $field: S) -> &mut Self { |
useless use of `vec!`: src/matches.rs#L309
error: useless use of `vec!` --> src/matches.rs:309:23 | 309 | let strings = vec!["3-1", "", "3-0", "3--5", "0-0", " 9-", " - 118 "]; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["3-1", "", "3-0", "3--5", "0-0", " 9-", " - 118 "]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec = note: `#[deny(clippy::useless_vec)]` implied by `#[deny(warnings)]`
this expression creates a reference which is immediately dereferenced by the compiler: src/matches.rs#L192
error: this expression creates a reference which is immediately dereferenced by the compiler --> src/matches.rs:192:27 | 192 | votes: remove(&mut map, &format!("{}votes", prefix))? | ^^^^^^^^ help: change this to: `map` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: src/matches.rs#L189
error: this expression creates a reference which is immediately dereferenced by the compiler --> src/matches.rs:189:37 | 189 | prereq_match_id: remove(&mut map, &format!("{}prereq_match_id", prefix))? | ^^^^^^^^ help: change this to: `map` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: src/matches.rs#L186
error: this expression creates a reference which is immediately dereferenced by the compiler --> src/matches.rs:186:43 | 186 | is_prereq_match_loser: remove(&mut map, &format!("{}is_prereq_match_loser", prefix))? | ^^^^^^^^ help: change this to: `map` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: src/matches.rs#L182
error: this expression creates a reference which is immediately dereferenced by the compiler --> src/matches.rs:182:24 | 182 | remove(&mut map, &format!("{}id", prefix))? | ^^^^^^^^ help: change this to: `map` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L60
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:60:23 | 60 | pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/matches.rs:153:5 | 153 | builder_o!(player2_votes, u64); | ------------------------------ | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder_o` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 60 - pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { 60 + pub fn $field(&mut self, $field: $field_type) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L60
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:60:23 | 60 | pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/matches.rs:152:5 | 152 | builder_o!(player1_votes, u64); | ------------------------------ | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder_o` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 60 - pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { 60 + pub fn $field(&mut self, $field: $field_type) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L60
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:60:23 | 60 | pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/matches.rs:151:5 | 151 | builder_o!(winner_id, ParticipantId); | ------------------------------------ | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder_o` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 60 - pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { 60 + pub fn $field(&mut self, $field: $field_type) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L40
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:40:23 | 40 | pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/matches.rs:150:5 | 150 | builder!(scores_csv, MatchScores); | --------------------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 40 - pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { 40 + pub fn $field(&mut self, $field: $field_type) -> &mut Self { |
`to_string` applied to a type that implements `Display` in `format!` args: src/matches.rs#L63
error: `to_string` applied to a type that implements `Display` in `format!` args --> src/matches.rs:63:52 | 63 | scores.push_str(&format!("{}{}", sep, s.to_string())); | ^^^^^^^^^^^^ help: remove this | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args = note: `#[deny(clippy::to_string_in_format_args)]` implied by `#[deny(warnings)]`
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L70
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:70:23 | 70 | pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/attachments.rs:67:5 | 67 | builder_so!(description); | ------------------------ | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder_so` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 70 - pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { 70 + pub fn $field<S: Into<String>>(&mut self, $field: S) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L70
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:70:23 | 70 | pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/attachments.rs:66:5 | 66 | builder_so!(url); | ---------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: this error originates in the macro `builder_so` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 70 - pub fn $field<'a, S: Into<String>>(&'a mut self, $field: S) -> &'a mut Self { 70 + pub fn $field<S: Into<String>>(&mut self, $field: S) -> &mut Self { |
the following explicit lifetimes could be elided: 'a: src/macroses.rs#L60
error: the following explicit lifetimes could be elided: 'a --> src/macroses.rs:60:23 | 60 | pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { | ^^ ^^ ^^ | ::: src/attachments.rs:65:5 | 65 | builder_o!(asset, Vec<u8>); | -------------------------- | | | in this macro invocation | in this macro invocation | in this macro invocation | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[deny(clippy::needless_lifetimes)]` implied by `#[deny(warnings)]` = note: this error originates in the macro `builder_o` (in Nightly builds, run with -Z macro-backtrace for more info) help: elide the lifetimes | 60 - pub fn $field<'a>(&'a mut self, $field: $field_type) -> &'a mut Self { 60 + pub fn $field(&mut self, $field: $field_type) -> &mut Self { |
this expression creates a reference which is immediately dereferenced by the compiler: src/attachments.rs#L35
error: this expression creates a reference which is immediately dereferenced by the compiler --> src/attachments.rs:35:25 | 35 | url: remove(&mut map, "asset_url")? | ^^^^^^^^ help: change this to: `map` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: src/attachments.rs#L34
error: this expression creates a reference which is immediately dereferenced by the compiler --> src/attachments.rs:34:31 | 34 | file_size: remove(&mut map, "asset_file_size")?.as_u64(), | ^^^^^^^^ help: change this to: `map` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: src/attachments.rs#L31
error: this expression creates a reference which is immediately dereferenced by the compiler --> src/attachments.rs:31:34 | 31 | content_type: remove(&mut map, "asset_content_type")? | ^^^^^^^^ help: change this to: `map` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
this expression creates a reference which is immediately dereferenced by the compiler: src/attachments.rs#L28
error: this expression creates a reference which is immediately dereferenced by the compiler --> src/attachments.rs:28:31 | 28 | file_name: remove(&mut map, "asset_file_name")? | ^^^^^^^^ help: change this to: `map` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[deny(clippy::needless_borrow)]` implied by `#[deny(warnings)]`
use of deprecated struct `chrono::Date`: Use `NaiveDate` or `DateTime<Tz>` instead: src/lib.rs#L259
error: use of deprecated struct `chrono::Date`: Use `NaiveDate` or `DateTime<Tz>` instead --> src/lib.rs:259:26 | 259 | created_before: &Date<Local>, | ^^^^
use of deprecated struct `chrono::Date`: Use `NaiveDate` or `DateTime<Tz>` instead: src/lib.rs#L258
error: use of deprecated struct `chrono::Date`: Use `NaiveDate` or `DateTime<Tz>` instead --> src/lib.rs:258:25 | 258 | created_after: &Date<Local>, | ^^^^
use of deprecated struct `chrono::Date`: Use `NaiveDate` or `DateTime<Tz>` instead: src/lib.rs#L13
error: use of deprecated struct `chrono::Date`: Use `NaiveDate` or `DateTime<Tz>` instead --> src/lib.rs:13:13 | 13 | use chrono::Date; | ^^^^ | note: the lint level is defined here --> src/lib.rs:10:9 | 10 | #![deny(warnings)] | ^^^^^^^^ = note: `#[deny(deprecated)]` implied by `#[deny(warnings)]`
Clippy
Clippy had exited with the 101 exit code
Format
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Format
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions/cache@v2, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/